search

PaperMC / Waterfall

BungeeCord fork that aims to improve performance and stability.
https://papermc.io
MIT License
741 stars 302 forks source link

Entity Rewrite - Settings get reset #835

Open linsaftw opened 11 months ago

linsaftw commented 11 months ago

When entity rewrite is disabled from waterfall.yml file, settings get reset each time you switch servers.

image image

This only happens since 24b7e51ed557baf3dbdeeb5ca94f445f08007127 upstream update.

linsaftw commented 11 months ago 
// Something deeper is going wrong here, but, as it stands, this project is EOL, so, we'll just shove this through.
if (user.getSettings() != null)
{
    ch.write( user.getSettings() );
}

I just forced this piece of code to always write settings and it fixed the issue.

Janmm14 commented 11 months ago

I feel like if you would test his with bungee, this kind of bug would also get fixed in bungee (if bungee has it what it really sounds like here) if you open issue there.

electronicboy commented 11 months ago

disabling entity metadata rewriting is not a thing on bungee

Janmm14 commented 11 months ago

uh ok i didnt check code in detail here.

edit: uh but 1.20 client doesnt really do entity rewriting on bungee as well?

electronicboy commented 11 months ago

Looks like I got the check backwards, this should be mitigated