search

PaperMC / docs

Documentation for all projects under the PaperMC umbrella.
https://docs.papermc.io/
BSD 2-Clause "Simplified" License
43 stars 112 forks source link

Fix wrong version reference in API call #328

Closed delath closed 8 months ago

delath commented 8 months ago

MINECRAFT_VERSION="1.20.4" is surely a copy/paste oversight, we need to obtain the build of the LATEST_VERSION and not of the MINECRAFT_VERSION, in the next steps we are rightfully referring only to the LATEST_VERSION.

zlataovce commented 8 months ago

in my opinion, it should rather use MINECRAFT_VERSION to match the example's description and the latest version query should be extracted into another example

olijeffers0n commented 8 months ago

Hi! Thank you for opening this PR, however this was not the intention we had behind this example. As @zlataovce said, this is technically correct as-is, however this latest version query should be a different example. If you would like to work on this, please open another PR! 😄

delath commented 8 months ago

Hi! Thank you for opening this PR, however this was not the intention we had behind this example. As @zlataovce said, this is technically correct as-is, however this latest version query should be a different example. If you would like to work on this, please open another PR! 😄

He didn't say that this is correct as-is, because it's not, however i think he is right and there should be two different examples, i may work on this when i have time.