DerEchtePilz
commented
8 months ago As a suggestion/question, would it make sense to put the pause statement behind a toggle that by default is turned on?
Closed notTamion closed 8 months ago
DerEchtePilz
commented
8 months ago As a suggestion/question, would it make sense to put the pause statement behind a toggle that by default is turned on?
notTamion
commented
8 months ago i didn't look into the component too much but as it looks to me that would require moving stuff around a lot so we can have different toggles for windows and linux. since i am very sure 90+% windows folks are gonna double click it i don't see much reason to have a toggle here.
DerEchtePilz
commented
8 months ago I guess that's fair. I don't use the script generator anyway, and also didn't expect that much more work for a toggle so you have my approval (not that you need it, anyway)
notTamion
commented
8 months ago i know this is technically completely out of scope for this pr (but opening a pr for this small thing is eeh) but shouldn't we have the gen add "nogui" instead of "--nogui" that way it doesn't crash on older versions
olijeffers0n
commented
8 months ago i know this is technically completely out of scope for this pr (but opening a pr for this small thing is eeh) but shouldn't we have the gen add "nogui" instead of "--nogui" that way it doesn't crash on older versions
Yes, we should. Feel free to add that to this PR if you would like, and I will rename the commit on merge
adds an @echo off in front of all windows scripts and adds a pause statement after if auto restart is disabled. This is because people on windows tend to double click the start.bat instead of opening a terminal and running the script from there, which causes the terminal to close when the server stops without giving the user the option to look at e.g. crash logs, i have noticed a lot of people on the discord server just saying "my server stops without any crash log" because of this exact reason.