search

PaperMC / docs

Documentation for all projects under the PaperMC umbrella.
https://docs.papermc.io/
BSD 2-Clause "Simplified" License
43 stars 113 forks source link

Make userdev version be fetched dynamically #492

Closed Strokkur424 closed 1 month ago

Strokkur424 commented 1 month ago

Instead of hardcoding a version value or focing the user to fetch it itself (previous change to this site), it should just be fetched live.

I have no idea what I am doing, so suggest changes freely

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview e8fd87133b3ee69fd4d062a0c50cd258e5b34a83
Strokkur424 commented 1 month ago

No idea what the format issue is. If somebody can tell me, please do so

zlataovce commented 1 month ago

I'm not particularly fond of creating another component just for userdev, I'd much rather have it be a part of VersionFormattedCode (+ the placeholder should be documented in CONTRIBUTING.md)

Strokkur424 commented 1 month ago

@zlataovce actually thinking about it, maybe I should put that util method into util/versionUtils.ts. Give me a second

zlataovce commented 1 month ago

@zlataovce actually thinking about it, maybe I should put that util method into util/versionUtils.ts. Give me a second

yes, it should be cached in an expiring value