search

Paperback-iOS / app

Repository to host app releases, issues, and feature requests for Paperback
https://paperback.moe/
664 stars 20 forks source link

[BUG] Small navigationbar icons #139

Closed tychoregter closed 4 years ago

tychoregter commented 4 years ago

Describe the bug Compared to other iOS apps Paperback seems to have smaller navigationbar icons than other apps like the App Store, Apple Music and other apps following Apples design language.

Expected behaviour I think the icon size should be just a tiny but bigger (72px on @3 devices)

App Version I used v0.2 and v0.3 and it’s present on both (on multiple versions)

Screenshots 0AE74CD8-73E8-4412-AA43-EBC4A63457B6

FaizanDurrani commented 4 years ago

I don't control the icon size, SwiftUI does. So that's how Apple wants the icons to be in the tab bar

tychoregter commented 4 years ago

@FaizanDurrani you sure everything is working correctly? It might be using the @2 icon or something instead. Look at the difference in size between the App Store and Paperback, there’s definitely something wrong here. DA4496D2-46F9-4B98-927B-F3891489D137 ![Uploading 8293FD43-CE09-40FB-80B5-8C950903B154.png…]()

FaizanDurrani commented 4 years ago

like I said, I am using the standard SwiftUI method. I am not explicitly giving a size.

Its the same implementation as this https://developer.apple.com/documentation/swiftui/tabview

github-actions[bot] commented 7 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.