search

Paperfeed / LiuChan

A Chinese mouseover dictionary extension for Chrome
https://paperfeed.github.io/LiuChan
20 stars 11 forks source link

Cannot scroll settings page #10

Open manyfew opened 6 years ago

manyfew commented 6 years ago

This started to happen after I updated Chrome recently. Before the update, I was able to scroll up and down the LiuChan settings page, but now I can't.

Paperfeed commented 6 years ago

I do not have this problem, and have absolutely no idea what could cause this, especially since the options page has not been altered the last few updates. Is it still occurring to you? It might be an issue with Chrome itself.

On Sat, Mar 17, 2018 at 2:37 PM, Manuel Fernandez notifications@github.com wrote:

This started to happen after I updated Chrome recently. Before the update, I was able to scroll up and down the LiuChan settings page, but now I can't.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Paperfeed/LiuChan/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/ABj8V8phqJglAPICk3KNxzMA6i8bQUyyks5tfL0pgaJpZM4SutNt .

manyfew commented 6 years ago

I'm running Chrome version 65.0.3325.146, which version are you running?

Paperfeed commented 6 years ago

Ah... my chrome hadn't been updated. I see the problem now... I'm on it.

On Wed, Mar 28, 2018 at 2:30 PM, Manuel Fernandez notifications@github.com wrote:

I'm running Chrome version 65.0.3325.146, which version are you running?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Paperfeed/LiuChan/issues/10#issuecomment-376789498, or mute the thread https://github.com/notifications/unsubscribe-auth/ABj8V7W0uLkLneBc2dOL-i3-A_yOpbUiks5tizwigaJpZM4SutNt .

manyfew commented 6 years ago

Thanks!

Paperfeed commented 6 years ago

Ok, I pushed an update. Due to changes in Chrome the options page didn't work the right way. It's honestly a bug with Chrome in my opinion, because atm they create an iframe with 0 width and 0 height. I can't use responsive CSS because 100% of 0 is still 0 and I can't get the size of the actual viewport with Javascript. For now I have put a min-height of 500px so that it works at least, but it's not an ideal solution.

On Wed, Mar 28, 2018 at 3:11 PM, Manuel Fernandez notifications@github.com wrote:

Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Paperfeed/LiuChan/issues/10#issuecomment-376799921, or mute the thread https://github.com/notifications/unsubscribe-auth/ABj8V8QpRjCRuIWVb5oDBdZP8muhqtXoks5ti0WpgaJpZM4SutNt .

manyfew commented 6 years ago

Hey thanks, just tested. While this solution may not be technically ideal, from my user's perspective it gets the job done. In case this matters, I've noticed a lot of extensions (e.g. FoxyProxy) now devote an entire page to options, rather than a small superimposed page or frame such as Liuchan's (sorry... I don't know the technical terms).

Paperfeed commented 6 years ago

While that would have been the easiest solution (matter of setting "options_as_tab" to true), the chrome developer documentation strongly recommends against still as they will phase out that setting. That's why I chose to use this temporary fix instead.

Glad to hear it's working though 😊

On Fri, Mar 30, 2018, 11:49 Manuel Fernandez notifications@github.com wrote:

Hey thanks, just tested. While this solution may not be technically ideal, from my user's perspective it gets the job done. In case this matters, I've noticed a lot of extensions (e.g. FoxyProxy) now devote an entire page to options, rather than a small superimposed page or frame such as Liuchan's (sorry... I don't know the technical terms).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Paperfeed/LiuChan/issues/10#issuecomment-377444350, or mute the thread https://github.com/notifications/unsubscribe-auth/ABj8V6H5q-q_xWL8YS0ud-lRqmtBoTB-ks5tjblGgaJpZM4SutNt .