Open gkovacs opened 5 years ago
gkovacs
commented
5 years ago Since I'm not sure if you're still maintaining this extension or if you're interested in maintaining a firefox version yourself, I went ahead and published this on the Firefox add-on marketplace at https://addons.mozilla.org/en-US/firefox/addon/liuchan/ if you want to maintain it yourself let me know.
Paperfeed
commented
5 years ago Hi Geza, I am still maintaining my add-on.
In fact, I've been refactoring the "legacy" code to be more readable/modular/testable so that I more easily push out updates quickly without having to worry about introducing a bunch of new bugs, this is also why I haven't accepted the pull requests yet.
Firefox support is part of the next release.
Thank you for the bug fixes! I'll be sure to include them. I'll accept the pull requests as I implement the changes!
On Mon, Sep 17, 2018, 04:27 Geza Kovacs notifications@github.com wrote:
Since I'm not sure if you're still maintaining this extension or if you're interested in maintaining a firefox version yourself, I went ahead and published this on the Firefox add-on marketplace at https://addons.mozilla.org/en-US/firefox/addon/liuchan/ if you want to maintain it yourself let me know.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Paperfeed/LiuChan/pull/15#issuecomment-421876369, or mute the thread https://github.com/notifications/unsubscribe-auth/ABj8V4w7MyXpe1XunHxgkeCm1NrSFaaFks5ubwiVgaJpZM4WrGbS .
gkovacs
commented
5 years ago Awesome, happy to hear you're still maintaining this! Note for firefox support that this pull request only covers desktop firefox; I tried getting it working on firefox for android (which should in principle be implementable; this similar extension https://addons.mozilla.org/en-US/firefox/addon/zhongwen-chinese-english/ works on firefox) but it was a pain to debug as there are a few features missing in android ( https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_desktop_and_Android ) so getting full firefox support (including android) may be a bit more work than this pull request suggests.
Paperfeed
commented
5 years ago Getting this to work on Android would be quite a nice feature actually! I'll look into it. Having everything refactored should help with supporting different platforms as well :)
On Mon, Sep 17, 2018, 12:34 Geza Kovacs notifications@github.com wrote:
Awesome, happy to hear you're still maintaining this! Note for firefox support that this pull request only covers desktop firefox; I tried getting it working on firefox for android (which should in principle be implementable; this similar extension https://addons.mozilla.org/en-US/firefox/addon/zhongwen-chinese-english/ works on firefox) but it was a pain to debug as there are a few features missing in android ( https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_desktop_and_Android ) so getting full firefox support (including android) may be a bit more work than this pull request suggests.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Paperfeed/LiuChan/pull/15#issuecomment-421960779, or mute the thread https://github.com/notifications/unsubscribe-auth/ABj8V51b6zaoqGyrJd5qMYIjhmB8xKA1ks5ub3qdgaJpZM4WrGbS .
Turns out this extension can be made to work on firefox with some very trivial changes (see the last commit - https://github.com/Paperfeed/LiuChan/commit/5817b3fee99a27ed8eea08ecb742d46ecbc7060b ).