search

Paperfeed / LiuChan

A Chinese mouseover dictionary extension for Chrome
https://paperfeed.github.io/LiuChan
20 stars 11 forks source link

FR: Pop-up on <textarea> controls #7

Open manyfew opened 6 years ago

manyfew commented 6 years ago

In Firefox I used add-on Mandaring Popup. I created a very simple website, stored locally on my hard drive as a text file, which displayed a number of multi-line text input boxes, here is the code:

<body>
    <pre> <textarea cols="50" rows="10"></textarea>  <textarea cols="51" rows="10"></textarea>  <textarea cols="50" rows="10"></textarea></pre>
    <pre> <textarea cols="50" rows="10"></textarea>  <textarea cols="51" rows="10"></textarea>  <textarea cols="50" rows="10"></textarea></pre>
    <pre> <textarea cols="50" rows="10"></textarea>  <textarea cols="51" rows="10"></textarea>  <textarea cols="50" rows="10"></textarea></pre>
</body>

I've been using this for over 7 years as a Chinese text reader, where I would paste, or type, a bunch of Chinese text and then casually hover the mouse over the hanzi to get the English translation. Unfortunately, LiuChan doesn't appear to recognize text in <textarea> controls. It does, however, work on <input> controls. The difference is that the latter is a single-line input box, which is not very good for large texts:

The <textarea> tag defines a multi-line text input control.

Would it be possible to enable LiuChan to work on <textarea> controls too? Thanks!!

Paperfeed commented 6 years ago

Hey Manuel!

That should definitely be possible. I'll have a look.

I've been working on your submitted issues but I'm a bit under the weather atm so I'm not quite focused when I'm looking at my code. Progress is being made however as I've put in most of the theme customization options today, just need to fix a few bugs and improve usability before I release the update. I think I'll try to fix all of the issues you've put up here before I release though. Perhaps you'd be willing to do a beta test when it's ready?

Sincerely, Aldert

On Mon, Nov 6, 2017 at 4:17 PM, Manuel Fernandez notifications@github.com wrote:

In Firefox I used add-on Mandaring Popup. I created a very simple website, stored locally on my hard drive as a text file, which displayed a number of multi-line text input boxes, here is the code:

`

I used this a Chinese text reader, where I would paste, or type, a bunch of Chinese text and then casually hover the mouse over the hanzi to get the English translation. Unfortunately, LiuChan doesn't appear to recognize text in ` Then type the path to the file into Chrome's address bar and enter some Chinese characters in any of the textarea boxes. — You are receiving this because you commented. Reply to this email directly, view it on GitHub , or mute the thread .

manyfew commented 6 years ago

Cool, I look forward to that

manyfew commented 6 years ago

Is this well underway? :)