Paperfeed / LiuChan

A Chinese mouseover dictionary extension for Chrome
https://paperfeed.github.io/LiuChan
20 stars 11 forks source link

Notepad suggestions #9

Open manyfew opened 6 years ago

manyfew commented 6 years ago

Here are just a few suggestions and thoughts regarding the "Notepad" feature introduced in v1.1.1:

1. The Chinese pop-up appears behind the Notepad 2. Would be nice to have an option to "pin" the Notepad by default (title bar "keep open" button engaged). Currently, by default the Notepad gets hidden once the user clicks outside the Notepad area. 3. The single Notpad is the same on all tabs, but the contents is not propagated to other tabs where the Notepad is also open, until the tab is reloaded. Would be nice if there was a refresh button on the pop-up title bar to refresh its contents (or better yet, to refresh it automatically whenever the tab gains focus). 4. Doesn't seem to open in all pages, for example on my system it doesn't come up on www.baidu.com.

Thanks :)

Paperfeed commented 6 years ago

1.ooooops! I could've sworn I put the proper z-index, but it turns out during testing I kept turning on Liuchan after I turned on the notepad. They both had the same (max z-index). This is an easy fix.

2/3. I'll put in a refresh on tab change and save the pinned state.

  1. The notepad works fine on baidu.com for me. Strange...

I have some other features coming up, such as a flashcard system with exporting to Anki/Skritter. Any other suggestions?

On Wed, Jan 24, 2018 at 12:46 AM, Manuel Fernandez <notifications@github.com

wrote:

Here are just a few suggestions and thoughts regarding the "Notepad" feature introduced in v1.1.1:

1. The Chinese pop-up appears behind the Notepad 2. Would be nice to have an option to "pin" the Notepad by default (title bar "keep open" button engaged). Currently, by default the Notepad gets hidden once the user clicks outside the Notepad area. 3. The single Notpad is the same on all tabs, but the contents is not propagated to other tabs where the Notepad is also open, until the tab is reloaded. Would be nice if there was a refresh button on the pop-up title bar to refresh its contents (or better yet, to refresh it automatically whenever the tab gains focus). 4. Doesn't seem to open in all pages, for example on my system it doesn't come up on www.baidu.com.

Thanks :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Paperfeed/LiuChan/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/ABj8V3isdENhSzt04_TMT1loVWP7pQZVks5tNm9QgaJpZM4Rqf_S .

manyfew commented 6 years ago

Awesome :)

Regarding 4, my personal opinion is that this could turn into a case of "画蛇添足", that is, that you may be over-engineering the product.

I do use Anki a lot, but I use non-standard templates (not the usual two-way or three-way cards) and usually add images, audio and font colors. I'm not sure a third-party application will be able to replicate all the editing and formatting capabilities of Anki, but if it can't I will just end up using Anki directly. Furthermore, I tend to edit my own cards manually rather than mindlessly adding entries straight out of a dictionary. In my opinion, adding my own material into Anki is a key part of the study process.

In Firefox I use Mandarin Popup, which can only do one thing but does it very well. I've used it for nearly 8 years and I've never had any desire for it to do anything else. Unfortunately it doesn't work in later Firefox versions...

Ultimately, LiuChan is your creation. If you personally would find Anki integration useful for your own needs, then you should totally add it. If you are adding stuff just for the sake of making the extension more appealing, then you already know what I think :)

Paperfeed commented 6 years ago

Anki integration would be being able to easily export words/characters into Anki, not rewriting an Anki-like SRS system in Liuchan.

But truthfully LiuChan as it is does exactly what I want it to do, and I agree feature creep is something to be aware of. I'm mostly just adding features I think other people might like. Adding a system where you can save words and then export them to Anki/Skritter/Chinesepod and other learning platforms is relatively easy, that's why I'm considering adding them.

By the way, I've added your suggestions to the notepad. I'll push the update in a moment (after I do some more QA).

On Wed, Jan 24, 2018 at 2:18 AM, Manuel Fernandez notifications@github.com wrote:

Awesome :)

Regarding 4, my personal opinion is that this could turn into a case of "画蛇添足", that is, that you may be over-engineering the product.

I do use Anki a lot, but I use a custom templates (not the usual two-way or three-way cards), and I'm not sure a third-party application will be able to replicate all the editing and formatting capabilities of Anki, in which case I will just end up using Anki directly. Furthermore, I tend to edit my own cards manually rather than mindlessly adding entries straight out of a dictionary. In my opinion, adding my own material into Anki is part of the study process.

In Firefox I use Mandarin Popup, which can only do one thing but does it very well. I've used it for nearly 8 years and I've never had any desire for it to do anything else. Unfortunately it doesn't work in later Firefox versions...

Ultimately, LiuChan is your creation. If you personally would find Anki integration useful for your own needs, then you should totally add it. If you are adding stuff just for the sake of making the extension more appealing, then you already know what I think :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Paperfeed/LiuChan/issues/9#issuecomment-359988325, or mute the thread https://github.com/notifications/unsubscribe-auth/ABj8V44SQEVNQNKJV-xCWlY8DH7pfx-Iks5tNoTtgaJpZM4Rqf_S .