Closed kalinon closed 3 years ago
Wonderful, thanks! Let's keep it open for a day or two more in case you think of anything else to add and then merge.
@docelic sounds good. https://github.com/Papierkorb/toka/pull/2 is also needed to get error free shard installs.
➜ bindgen git:(crystal-1.0.0) shards
Resolving dependencies
Fetching https://github.com/papierkorb/toka.git
Fetching https://github.com/spoved/spoved.cr.git
Fetching https://github.com/icyleaf/halite.git
Unable to satisfy the following requirements:
- `crystal (~> 0.24, >= 0.24.1)` required by `toka 0.1.2`
- `crystal (~> 1.0, >= 1.0.0)` required by `spoved 0.5.0`
I temporarily changed it to my fork to ensure the shards install work:
➜ bindgen git:(crystal-1.0.0) ✗ shards update
Resolving dependencies
Fetching https://github.com/kalinon/toka.git
Fetching https://github.com/spoved/spoved.cr.git
Fetching https://github.com/kalinon/halite.git
Using toka (0.1.2 at 72a06e1)
Using halite (0.11.0 at d51d5e7)
Using spoved (0.5.1)
Writing shard.lock
This is a clean merge and fix of master and my fork. Ive fixed various issues with the specs. major changes include:
spec tests: all passed