search

Papierkorb / bindgen

Binding and wrapper generator for C/C++ libraries
GNU General Public License v3.0
179 stars 18 forks source link

Small fixes for 1.0.0 release #116

Closed kalinon closed 3 years ago

kalinon commented 3 years ago

added and cleaned up more logging added reserved keyword "in" to crystal list added check for matching type name

Papierkorb commented 3 years ago

LGTM, except for the following:

  1. Please have a descriptive name for any & all commits. Your commits are fine in that, except for https://github.com/Papierkorb/bindgen/pull/116/commits/5dbfdab67dce3fd45534ce5f7bd230faca8df045
  2. Instead of fixing the commit mentioned, you can also just fixup it into the previous commit. Force-pushing on a PR is perfectly fine for me :+1:

Could you do that? Then I think we can merge it