search

Papierkorb / bindgen

Binding and wrapper generator for C/C++ libraries
GNU General Public License v3.0
179 stars 18 forks source link

VirtualOverride: handle implicit polymorphic types #74

Closed HertzDevil closed 4 years ago

HertzDevil commented 4 years ago

Fixes an edge case where a C++ type may be polymorphic even if it doesn't define any virtual methods on its own, as long as it inherits from another polymorphic type. Luckily this doesn't affect qt5.cr.

Before this patch, Test::Implicit would not use a jumptable at all.

Papierkorb commented 4 years ago

Is the commit https://github.com/Papierkorb/bindgen/pull/74/commits/0242e792cc4121357904eeec1080238124a6c5a9 required?

HertzDevil commented 4 years ago

Nope, only the last commit is

Papierkorb commented 4 years ago

Thanks, Merged.