PapirusDevelopmentTeam / arc-kde

Arc KDE customization
https://git.io/arc-kde
GNU General Public License v3.0
904 stars 53 forks source link

[Aurorae] close button and maximized window #12

Closed abouvier closed 7 years ago

abouvier commented 7 years ago

A click on the upper right pixel of the screen doesn't close a maximized window when using the Aurorae Arc theme. There is a 1 or 2 px difference between the close button and the edge. Maybe because the window corners are rounded and not rectangular. Anyway, it's very annoying :p

varlesh commented 7 years ago

Anyway, it's very annoying

You can use breeze window decoration if you very annoying with Arc KDE or fix that - sources available! Also arc-kde aurorae themes have only one pixel for decoration - it's very tiny!

abouvier commented 7 years ago

I don't know how to fix that :p But is it an unexpected behavior, or is it done on purpose?

abouvier commented 7 years ago

Ah! The culprit is the property ButtonMarginTop in Arcrc. Changing the value from 2 to 0 solve the problem.

SmartFinn commented 7 years ago

@abouvier can't add it to upstream, because it looks ugly on a maximized window.

You can fix it manually:

sed -i.orig -e 's/ButtonMarginTop=[0-9]\+/ButtonMarginTop=0/' \
    -e 's/TitleEdgeTop=[0-9]\+/TitleEdgeTop=5/' \
    /usr/share/aurorae/themes/Arc*/Arc*rc
ArchangeGabriel commented 7 years ago

@SmartFinn Something I don’t understand: in Breeze for instance, the button is not glued to the side or top, but clicking on the top right corner works. What makes arc so special here that being able to click this button by going in the top right corner requires a visual change? Can’t it work with the actual aspect?

abouvier commented 7 years ago

@ArchangeGabriel I think the button in Breeze is actually maximized to the height of the tittle bar, but that the padding is in the button image itself.

ArchangeGabriel commented 7 years ago

That does totally make sense. @SmartFinn Do you think this can be done here too?

SmartFinn commented 7 years ago

Guys, Breeze ≠ Aurorae. I tried a lot of combination to make it work on Aurorae, but I had no success.

DoS007 commented 5 years ago

I'm using Kubuntu 18.04.1 and have the same problem. I installed the arc dark theme by system settings and chose arc dark decoration in the decoration menu of system settings. But I have the problem this topic is about.

sed -i.orig -e 's/ButtonMarginTop=[0-9]+/ButtonMarginTop=0/' \ -e 's/TitleEdgeTop=[0-9]+/TitleEdgeTop=5/' \ /usr/share/aurorae/themes/Arc/Arcrc

This does not work for me. I have no such directory.

find / -iname 'arc*rc' 2>/dev/null /home/dos/.local/share/aurorae/themes/Arc/Arcrc /home/dos/.local/share/aurorae/themes/Arc-Dark/Arc-Darkrc

(no other results).

So I changed in both files TitleEdgeTop=5 and ButtonMarginTop=0. The problem still remains.

?!

janhartman commented 5 years ago

@DoS007 Have you managed to fix the problem somehow? I have the same issue, changing the *rc files does not do anything.

DoS007 commented 5 years ago

@janhartman I think, I didn't fix it. But I'm now back to windows. Scaling with 4k monitor is very inferior in linux plattform. I hope wayland and better nvidia driver will fix that in the future.