PapirusDevelopmentTeam / arc-kde

Arc KDE customization
https://git.io/arc-kde
GNU General Public License v3.0
904 stars 53 forks source link

[Suggestion] could we have an option to have these window controls? #34

Closed ghost closed 7 years ago

ghost commented 7 years ago

Hello, I love everything about this theme besides the window controls. I'd like to have an option to pick these instead (just those three buttons, minimize, maximize and close).

It's already here but it doesn't work like this one. https://github.com/andreisergiu98/arc-flatabulous-theme

SmartFinn commented 7 years ago

Hi. I don't have a plan to add a theme with those window controls. If someone creates a fork, I'll add a link to it.

ghost commented 7 years ago

I would but I don't know how. Could basic knowledge of CSS make this happen? If so could you point me at the .css file that I should be editing?

SmartFinn commented 7 years ago

You only need Inkscape skills. close.svgz, maximize.svgz and minimize.svgz files should look like those sources https://github.com/andreisergiu98/arc-flatabulous-theme/tree/master/common/unity/window-buttons

ghost commented 7 years ago

Wow that's cool. I'm not bad in Inkscape as well. Thanks.

ghost commented 7 years ago

I edited them out but can't seem to find them in the system. Where should I replace mine with the original ones?

SmartFinn commented 7 years ago

@skullscream Look in ~/.local/share/aurorae/themes/ or /usr/share/aurorae/themes/.

ghost commented 7 years ago

I replaced my svgz files with the arc dark ones and this is what I get http://i.imgur.com/enLwwft.png

Any idea what it might be?

Here are the three files if you'd like to try for yourself http://www.filedropper.com/buttons_1

Those buttons still work, I'm still able to close, minimize and maximize they are just not visible for some reason.

SmartFinn commented 7 years ago

Each button in the svgz file must have ID (Object - Object Properties... in Inkscape).

IDs:

The documentation https://techbase.kde.org/User:Mgraesslin/Aurorae#Buttons

ghost commented 7 years ago

This is a rectangle without a fill/stroke and then circle put into it and grouped together, yes?

SmartFinn commented 7 years ago

There no a rectangle, just circle inside the group with ID.

ghost commented 7 years ago

I still have no idea what I'm doing wrong.

SmartFinn commented 7 years ago

Add your svgz files into zip archive and attach here, I'll look.

ghost commented 7 years ago

files.zip Sorry to bother you this much, just never did this before, objects, icons....

SmartFinn commented 7 years ago

You changed Label, not an ID screenshot from 2017-05-05 21-05-18

ghost commented 7 years ago

Still a nope, unfortunately. http://i.imgur.com/YEbOHZ6.png Even after I changed all IDs like that for every button.

SmartFinn commented 7 years ago

Works on my system Arc-Dark.tar.gz screenshot from 2017-05-05 21-32-48

ghost commented 7 years ago

Had to re-install the theme and icon pack. Now it's working, finally. They still could do some work on my part so hovering and pressing is more obvious. Thank you so much dude. Should I fork this one and make changes or?

SmartFinn commented 7 years ago

As you wish. Ping me if you made a repo with these themes. I'll add a link to it in the extras.

ghost commented 7 years ago

Ok. And how do I ping exactly? :D Is that github's version of PMs?

SmartFinn commented 7 years ago

@skullscream create a separate repository that contains only the modified Aurorae themes like this project https://github.com/simoniz0r/kde-gaps

Also, change a name of the repo to Arc-KDE-Flatabulous-theme or something like that.

danielsanfr commented 7 years ago

@skullscream I already gave you a star. It was very good what you did. I just wondered if the size of the controls should be a little smaller?

ghost commented 7 years ago

They are 16x16px which seems pretty good. They take up most of the window which is what I intended. Smaller ones might be harder to hit when rage quitting :D