search

PapirusDevelopmentTeam / arc-kde

Arc KDE customization
https://git.io/arc-kde
GNU General Public License v3.0
901 stars 53 forks source link

In virtual desktop plasmoid, the active desktop's windows outlines are covered #71

Closed Tichy closed 6 years ago

Tichy commented 6 years ago

See screenshot:

Breeze Dark screenshot_20170927_085435

Arc Dark screenshot_20170927_085401

varlesh commented 6 years ago

Arc not use transparent for Highlight color - it's style!

varlesh commented 6 years ago

And workspace actived - this not need, because you see this workspace now....

varlesh commented 6 years ago

Also Arc Color have transparent Highlight Pager

Tichy commented 6 years ago

I see. Somehow it looked to me like a bug, instead of something done on purpose.

varlesh commented 6 years ago

@Tichy Because window preview stroke (not pager stroke) draw plasmashell, i can't fix that. I like this style: image

varlesh commented 6 years ago

It's can fixed on Pager code only. /usr/share/plasma/plasmoids/org.kde.plasma.pager/contents/ui/main.qml:

hoverEnabled: true

    function colorWithAlpha(color, alpha) {
        return Qt.rgba(color.r, color.g, color.b, alpha)
    }

    readonly property color windowActiveOnActiveDesktopColor: colorWithAlpha(theme.textColor, 0.6)
    readonly property color windowInactiveOnActiveDesktopColor: colorWithAlpha(theme.textColor, 0.35)
    readonly property color windowActiveColor: colorWithAlpha(theme.textColor, 0.5)
    readonly property color windowActiveBorderColor: theme.textColor
    readonly property color windowInactiveColor: colorWithAlpha(theme.textColor, 0.17)
    readonly property color windowInactiveBorderColor: colorWithAlpha(theme.textColor, 0.5)

    function action_addDesktop() {
        pagerModel.addDesktop();
    }
varlesh commented 6 years ago

Fixed code:

readonly property color windowActiveOnActiveDesktopColor: colorWithAlpha(theme.textColor, 0.6)
    readonly property color windowInactiveOnActiveDesktopColor: colorWithAlpha(theme.textColor, 0.35)
    readonly property color windowActiveColor: colorWithAlpha(theme.textColor, 0.5)
    readonly property color windowActiveBorderColor: colorWithAlpha(theme.textColor, 0.0)
    readonly property color windowInactiveColor: colorWithAlpha(theme.textColor, 0.17)
    readonly property color windowInactiveBorderColor: colorWithAlpha(theme.textColor, 0.0)

image

varlesh commented 6 years ago

@Tichy See, change transparency only for windowActiveBorderColor & windowInactiveBorderColor. It's looking better ))