PapirusDevelopmentTeam / materia-kde

Materia KDE customization
https://git.io/materia-kde
GNU General Public License v3.0
611 stars 40 forks source link

Adaptive opacity support for KDE panel #147

Closed onnyyonn closed 1 year ago

onnyyonn commented 1 year ago

KDE panels can have an option for adaptive opacity if the following is in the metadata desktop file:

[AdaptiveTransparency]
enabled=true

Can you please add this to Materia?

onnyyonn commented 1 year ago

Here is the relevant merge https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/97

varlesh commented 1 year ago

i'm not understand why this needed on Materia's themes. Our panel not have opacity

onnyyonn commented 1 year ago

That is what I am requesting. Are you open to implementing opacity? The panel will not be transparent by default. But the users will have an option to choose full or adaptive transparency.

If you need it, I can try to create a PR to implement this feature.

varlesh commented 1 year ago

It's can be implementing only on panels or dialogs (widgets) too? How it's will be worked with old Plasma versions, for example LTS?

varlesh commented 1 year ago

hm... i'm test it with dialogs and this worked too. Very interested

varlesh commented 1 year ago

But it's worked wrong... When i'm set opaque option - dialogs applying color from panel: For example, panel-background 20% opacity color #121212 and dialogs/background 20% opacity color #1e1e1e image

varlesh commented 1 year ago

That is, when adding the [AdaptiveTransparency] enabled=true option, the widget color is applied from the panel color, which violates the original implementation of the style.

varlesh commented 1 year ago

How it should look like: image

onnyyonn commented 1 year ago

Yes the transparency applies to dialogs too. Here is the relevant merge https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/119/

If the dialogs are taking color of the panel, that is probably a bug!

onnyyonn commented 1 year ago

How it's will be worked with old Plasma versions, for example LTS?

It will not be available for old Plasma versions.

varlesh commented 1 year ago

Well, since this is an error and there is no support for the LTS version, I think we should not add this option.