search

PapirusDevelopmentTeam / papirus-folders

a script that lets you change the colors of folders in Papirus icon theme
https://git.io/papirus-folders
MIT License
600 stars 32 forks source link

I ask your authorisation to fork this development and to modify for my own theme #3

Closed gusbemacbe closed 5 years ago

gusbemacbe commented 5 years ago

Hello @SmartFinn and @varlesh !

I would like to fork your shell script and modify it for my own icons theme which comes with colourful folders.

Gustavo

SmartFinn commented 5 years ago

Sure, do anything the MIT license permits. Also, look on build_color_folders.sh script, that allows to build icons by color replacing and creating symlinks for Folder color.

Feel free to ask me for adapting the scripts to your icon theme.

gusbemacbe commented 5 years ago

Hi @SmartFinn !

The papirus-folders is very easy than build_color_folders.sh. In the file build_color_folders.sh my folders icons have more than 5 colours than your folders icons with just 4 colours.

I have tested and it worked. Here are two screenshots:

result1

result2

I have a doubt. Does it work with all file managers (Caja, Dolphin, Nemo, Thunar, etc.)?

Thank you for your authorisation!

SmartFinn commented 5 years ago

@gusbemacbe

I have a doubt. Does it work with all file managers (Caja, Dolphin, Nemo, Thunar, etc.)?

Yes. It works with any FM and any DE. The script creates/changes symlinks in the icon theme directory and updates icon cache. The weakness of this method is the need to restore the selected folder color after each update. We do it in our installation script https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/install.sh#L79 and in our deb package https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/packaging/debian/postinst#L33

SmartFinn commented 5 years ago

@gusbemacbe I'll help you to adaptive build_color_folders.sh script for your icon theme. I see a lot of issue in https://github.com/gusbemacbe/suru-plus should I open PR in https://github.com/gusbemacbe/suru-plus-alpha?

Icons in places/16 and places/symbolic no need a color suffix, because they don't have a colors.

my folders icons have more than 5 colours

I see only 3 color, the others colors are white with differ opacity value.

gusbemacbe commented 5 years ago

@SmartFinn

The weakness of this method is the need to restore the selected folder color after each update. We do it in our installation script https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/install.sh#L79 and in our deb package https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/packaging/debian/postinst#L33

Thank you for the advice. I will give the users who will read tutorial.

@gusbemacbe I'll help you to adaptive build_color_folders.sh script for your icon theme. I see a lot of issue in https://github.com/gusbemacbe/suru-plus should I open PR in https://github.com/gusbemacbe/suru-plus-alpha?

Yes, please. Suru++ Alpha is for analysing and testing.

Can I know what issues?

I see only 3 color, the others colors are white with differ opacity value.

Yes, it is. I have difficult to redesign folder-custom because of white colours with opacity value.

SmartFinn commented 5 years ago

@gusbemacbe

Can I know what issues?

Icons in places/16 and places/symbolic no need a color suffix, because they don't have colors.

That is first. The second is a lot of broken symlinks and typo in icon names. The third is color places icons without a color suffix.

gusbemacbe commented 5 years ago

Thank you for reporting. You are free to make a PR, fixing them.