PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.6k stars 416 forks source link

missing icon for Lubuntu #1454

Closed Daniel-Deepak-Dev closed 6 years ago

Daniel-Deepak-Dev commented 6 years ago

@varlesh I am respecting you I don't understand what are you saying. I'm new to version controller github. I barely know how to use it.

Its your wish to work on it or close it again.

Some of missing icons for Lubuntu:

  1. LXTerminal
  2. Desktop Preferences
  3. Authentication
  4. Run
  5. System Profiler and Benchmark
  6. Albert Launcher
  7. Default application for LXSessions
  8. No dark mode for iconify all windows in taskbar icons

My suggestions:

  1. Visual Studio Code icon (its been updated in Windows and Mac)
  2. Docky icon Little big than usual icons

icon

varlesh commented 6 years ago

LXTerminal Desktop Preferences Authentication Run System Profiler and Benchmark Albert Launcher Default application for LXSessions No dark mode for iconify all windows in taskbar icons

Your request multiply and I don't know all icon names. show screenshot with every icon and paste icon name from desktop file. See more info here: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme#icon-request

lxterminal - use StartupWMClass, it's not our bug. Albert Launcher - this icon exist: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/Papirus/48x48/apps/albert.svg

visual studio code alrready updated and we discussed about this earlier: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/727

Daniel-Deepak-Dev commented 6 years ago

Application name and Icon name: LXTerminal

lxterminal

Description: already exist but while increasing the size of the icon it blurs

Application name and Icon name : System Profiler and Benchmark

spb

Description: same problem as Lxterminal

Application name and icon name: Alsamixergui alsa

Description: normally Blured

Daniel-Deepak-Dev commented 6 years ago

@varlesh is it ok? I couldn't find other icons in usr/share/applications

Thanks for your response

varlesh commented 6 years ago

Application name and Icon name : System Profiler and Benchmark Application name and icon name: Alsamixergui

it's wrong icon names. open desktop-file on text editor and see item icon=

about blured terminal icon - need added StartupWMClassoption to desktop file, see example bug: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/902

varlesh commented 6 years ago

hardinfo like as System Profiler and Benchmark icon hardcoded: Icon=/usr/share/hardinfo/pixmaps/logo.png https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/hardinfo/trusty/view/head:/debian/hardinfo.desktop

alsamixergui hardcoded too: Icon=/usr/share/pixmaps/alsamixergui.xpm https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/alsamixergui/trusty/view/head:/debian/alsamixergui.desktop

varlesh commented 6 years ago

you can fix hardinfo icon use hardcode-fixer: https://github.com/Foggalong/hardcode-fixer

For AlsaMixerGUI issue openned or change icon name manually to alsamixergui: https://github.com/Foggalong/hardcode-fixer/issues/339

varlesh commented 6 years ago

No dark mode for iconify all windows in taskbar icons

Now available only this variants Papirus - light window & dark panel (by default on mostly DE's) Papirus Dark - dark window & dark panel Papirus Light - light window & light panel

SmartFinn commented 6 years ago

@danielnewbie

  1. LXTerminal - icon already there: screenshot from 2018-08-31 18-00-15

  2. Desktop Preferences - icon already there: screenshot from 2018-08-31 18-00-33

  3. Authentication - on your screenshot I see Papirus icon

  4. Run - hardcoded

  5. System Profiler and Benchmark - hardcoded

  6. Albert Launcher - icon already there: screenshot from 2018-08-31 17-55-16

  7. Default application for LXSessions - icon already there: screenshot from 2018-08-31 17-50-39

  8. No dark mode for iconify all windows in taskbar icons - try Papirus Dark icon theme, but you have to chose dark theme with dark menu and panel.

Visual Studio Code icon (its been updated in Windows and Mac)

Mac and Linux version have differ icon than Windows version.

Docky icon Little big than usual icons

It's not, 48 px icon uses 4px margins like other square icons.

I see some apps on Docky no have icon or have blurry icon. Try to fix it by adding StartupWMClass to app desktop-file. See StartupWMClassFixer

SmartFinn commented 6 years ago

The other unresolved issues cannot be fix it on our side. So I close this issue.