[Symlink Request] Visual Studio Code

ghost commented 6 years ago

Symlink: code-oss Target: visual-studio-code

SmartFinn commented 6 years ago

Which package using this icon name?

ghost commented 6 years ago

thanks. Arch code package use this icon name.

ghost commented 5 years ago

Shouldn't 'code-oss' linking to 'com.visualstudio.code.oss.svg' instead of 'visual-studio-code'?

They not repackaging VSCode but doing an OSS build if I interpret the package description correctly: "The Open Source build of Visual Studio Code (vscode) editor"

Also code-oss is the default product.json applicationName in the master branch.

{
    "nameShort": "Code - OSS",
    "nameLong": "Code - OSS",
    "applicationName": "code-oss",
    "dataFolderName": ".vscode-oss",
    "win32MutexName": "vscodeoss",
    "licenseName": "MIT",
    "licenseUrl": "https://github.com/Microsoft/vscode/blob/master/LICENSE.txt",
    "win32DirName": "Microsoft Code OSS",
    "win32NameVersion": "Microsoft Code OSS",
    "win32RegValueName": "CodeOSS",
    "win32AppId": "{{E34003BB-9E10-4501-8C11-BE3FAA83F23F}",
    "win32x64AppId": "{{D77B7E06-80BA-4137-BCF4-654B95CCEBC5}",
    "win32UserAppId": "{{C6065F05-9603-4FC4-8101-B9781A25D88E}",
    "win32x64UserAppId": "{{C6065F05-9603-4FC4-8101-B9781A25D88E}",
    "win32AppUserModelId": "Microsoft.CodeOSS",
    "win32ShellNameShort": "C&ode - OSS",
    "darwinBundleIdentifier": "com.visualstudio.code.oss",
    "linuxIconName": "com.visualstudio.code.oss",
    "licenseFileName": "LICENSE.txt",
    "reportIssueUrl": "https://github.com/Microsoft/vscode/issues/new",
    "urlProtocol": "code-oss",
    "extensionAllowedProposedApi": [
        "ms-vscode.references-view"
    ]
}

Even better would be if the Arch maintainer would switch to the 'com.visualstudio.code.oss' icon, as it the official icon name for code-oss.

SmartFinn commented 5 years ago

@Ghostium that makes sense. I did change the symlink. Thanks.

PapirusDevelopmentTeam / papirus-icon-theme

[Symlink Request] Visual Studio Code #1473