search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.65k stars 423 forks source link

Kmymoney icons #1629

Closed jEsuSdA closed 3 years ago

jEsuSdA commented 5 years ago

Hi!

There is an app KmyMoney icons, but It will be great complete all the icons KmyMoney uses in his interface.

Nowadays KmyMoney loads some Papirus Icons, but some other are not existing.

Maybe some of them could be done with a simple symlink.

Here the icons:

account account

account-types-asset account-types-asset

account-types-cash account-types-cash

account-types-checking account-types-checking

account-types-credit-card account-types-credit-card

account-types-investments account-types-investments

account-types-liability account-types-liability

account-types-loan account-types-loan

account-types-savings account-types-savings

budget budget

categories categories

forecast forecast

home home

institution institution

investment investment

ledger ledger

online-banking online-banking

payee payee

report report

schedule schedule

The complete icon theme (in from /usr/share/kmymoney/icons/hicolors): hicolor.zip

And here, how it looks like now:

imagen

As you can see, some icons (calcultaor, categories, delete, ...) are from Papirus cause KmyMoney tries to load the icons from the desktop theme.

Thanks a lot!

varlesh commented 5 years ago

@jEsuSdA left sidebar icons hardcoded? You can check this please?Added any symlink for one icon

varlesh commented 5 years ago

for example:

cd /usr/share/icons/Papirus/22x22/actions
sudo ln -s go-home.svg home.svg
jEsuSdA commented 5 years ago

@varlesh

It works imagen

But no with 22x22 icons, but symbolic:

I did 

cd /usr/share/icons/Papirus/22x22/actions
sudo ln -s go-home.svg home.svg

and didn't work

I did

cd /usr/share/icons/Papirus/symbolic/actions
ln -s go-home-symbolic.svg home.svg

and this worked!

Maybe adding a ACTION folder in 64x64 size pixel folder of Papitus should work.

varlesh commented 5 years ago

KDE not use symbolic icons

jEsuSdA commented 5 years ago

@varlesh Yes, I know.

What I mean is that doing symlinks in 22x22 folder does not works, but doing the symlinks in symbolic folder do it.

I supppose that creating a ACTION folder into 64x64 size will work too.

varlesh commented 5 years ago

It's not hardcoded and this very good. But our symbolic icons not support kde color scheme css and this bad way...

jEsuSdA commented 5 years ago

@varlesh The thing is not to use symbolic, but colorful ones into 64x64 Papirus folder. I think. ;)

varlesh commented 5 years ago

@jEsuSdA Please report bug on KMyMoney for rendering icons on toolbar.... Mostly icons on toolbar not rendered normal: image See example icon account (yellow icon) - this icon have monochrome version too, but why rendered 32px for toolbar with 22px? It's bug!!!

varlesh commented 5 years ago

https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/Papirus/32x32/actions/account.svg https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/Papirus/22x22/actions/account.svg

jEsuSdA commented 5 years ago

@varlesh good job!

I fired the bug to KmyMoney team.

In my case, the icon inconsistency is worse than you, cause there are a mixture of color and symbolic icons in the left pannel.

imagen

And, of course, in the main toolbar, like you:

imagen

Here the KmyMoney bug: https://bugs.kde.org/show_bug.cgi?id=404959

Thanks a lot, @varlesh. I love the new icons you made. ;)

wrobelda commented 4 years ago

Thanks for reporting this issue, I am looking into it.

Nice icons, BTW!

wrobelda commented 3 years ago

Hi,

Please look at the changes in master branch regarding icons. Many of them were renamed, many new colorful icons were added to their symbolic counterparts and their usage within the app is now more consistent. Specifically, you want to look at:

varlesh commented 3 years ago

@wrobelda It's will be solved on next release?

wrobelda commented 3 years ago

@varlesh The upcoming 5.1.x maintenance release will have most of the known issues with icons unresolved. All icon issues are fixed in master and we hope to have a release sometime in Q2 this year.

varlesh commented 3 years ago

for me monochrome icons:

kmymoney.zip

varlesh commented 3 years ago

image