PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.64k stars 423 forks source link

New classes #2448

Closed varlesh closed 3 years ago

varlesh commented 3 years ago

Ok guys. We support more De's and earlier adhered to the concept monochrome tray icons wigh 2 colors:

KDE have classes:

As you see we have only one problem use succes status as ColorScheme-PositiveText or ColorScheme-Highlight. Yes... yes... we lost monochrome accent color, but can have more variation for status. OK. Now we dispute about Battery icon and we can't decide what to do: Now we have this:

image

Future @SmartFinn version:

image

Future @varlesh version: image

varlesh commented 3 years ago

@uvulpos Battery updated on master branch

mcnesium commented 3 years ago

Looks like class="ColorScheme-PositiveText" is now the default in all the battery icons. As far as I understood, this is the KDE-way of doing things. However, it breaks monochrome designs. For the state-ok icon, this has already been reverted to ColorScheme-Text to default to monochrome view. Is there a chance that this will happen to the battery icons, as well?

varlesh commented 3 years ago

@mcnesium Please see #2447.

varlesh commented 3 years ago

AC disconnected: image AC connected: image

uvulpos commented 3 years ago

Looks great! Good job! 😄

ozls commented 3 years ago

I don't understand why this version eventually won. It's beautiful, but I wholeheartedly agree with the input of @SmartFinn on bug #2447. My everyday situation is a laptop running on AC with a half empty battery that is not charging (for battery longevity reasons), and I find it very distracting to have the green accent in this case. On the other hand, in a situation where I'm running solely on battery, I would find it very useful to be reminded of its state constantly. So what gives ? Is there a practical reason behind this choice ? Can I do something ?

intrnl commented 3 years ago

Was wondering the same, I find the green battery to be distracting. image

95440b97d commented 3 years ago

Can this be reopened? I agree with @ozls. The version of @SmartFinn makes absolutely more sense.

Keeping the battery not fully charged (on purpose) and plugged in nags you with an green accent color where attention is not needed (we are plugged in after all).

Whereas when the battery is discharging there's no nagging accent color (the color is monochrome). Here a nagging color is actually beneficial to remind the user of something he needs to pay attention to.

Using stock Gnome desktop.