search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.65k stars 423 forks source link

[Hardcode-Tray] Some icons aren't white #248

Closed abouvier closed 7 years ago

abouvier commented 7 years ago

I use Arch with these pacakges:

$ pacman -Qm
arc-kde-git 20170102-1
hardcode-tray 3.6.4-1
papirus-icon-theme-git r654.7d64ca5a9-1

I tried these commands: $ hardcode-tray --conversion-tool Inkscape $ hardcode-tray --conversion-tool Inkscape --theme Papirus $ hardcode-tray --conversion-tool Inkscape --theme Papirus-Dark $ hardcode-tray --conversion-tool Inkscape --dark-theme Papirus-Dark --light-theme Papirus $ hardcode-tray --conversion-tool Inkscape --dark-theme Papirus --light-theme Papirus-Dark

But the result is always: screenshot_20170104_032225 HexChat and Discord are white but not Dropbox and Steam.

My global theme is Breeze but with Arc Dark panel and Papirus icons.

varlesh commented 7 years ago

this commands not supported:

--dark-theme Papirus-Dark --light-theme Papirus

because use CSS style for icons! BUT CSS Style not supported for tray apps (Non-KDE apps), see readme NOTE: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme#kde-color-scheme

My global theme is Breeze but with Arc Dark panel and Papirus icons.

You need use Papirus - for dark plasma theme & light window theme:

hardcode-tray --conversion-tool Inkscape --theme Papirus

Also not forgot apply icon theme on kde settings and for GTK-apps too and restart apps...

Also you can replace tray icons color with sed, command available on README

Arc Dark Plasma Theme - not support KDE Color scheme Arc Color - support KDE Color scheme

varlesh commented 7 years ago

Not confused ;)

For GTK DE: Papirus - dark panel & light windows Papirus-Dark - dark panel & dark windows ePapirus - mod for elementary (dark panel & light windows)

For KDE (if enabled support KDE Color scheme): Papirus - for dark plasma theme & light window theme Papirus Dark - for dark plasma theme & window theme or white plasma theme & window theme

For KDE (if disabled support KDE Color scheme): Papirus - for dark plasma theme & light window theme Papirus-Dark for dark plasma theme & dark window theme

Also you can modify colors for monochrome icons - use sed. Or disable KDE Color scheme on index.theme:

FollowsColorScheme=false
varlesh commented 7 years ago

tray icons for non-KDE apps not supported KDE Color scheme - change colors manually with sed

varlesh commented 7 years ago

Little note:

nicodorn commented 7 years ago

Hi varlesh!

First of all: Thank you very much for your work. I really like Papirus. Well, in fact I was suffering the same problem as abouvier. I'm using Papirus (not Papirus-Dark) because I have a light window theme and dark panels. But the Dropbox-Icon (besides some others) always displayed as in the picture abouvier posted: dark. All your proposals didn't do the trick for me. My solution was quite simple: I just copied the panel folders from Papirus-Dark to Papirus:

sudo rm -rf /usr/share/icons/Papirus/22x22/panel/ sudo rm -rf /usr/share/icons/Papirus/24x24/panel/ sudo cp -r /usr/share/icons/Papirus-Dark/22x22/panel/ /usr/share/icons/Papirus/22x22/ sudo cp -r /usr/share/icons/Papirus-Dark/24x24/panel/ /usr/share/icons/Papirus/24x24/

Maybe it'll help somebody. Have a nice day!

varlesh commented 7 years ago

I don't know why you have problem with dropbox. See source dropboxstatus-logo.svg:

<?xml version="1.0"?>
<svg xmlns="http://www.w3.org/2000/svg" height="22" width="22" version="1.1" viewBox="0 0 22 22" id="svg2">
 <defs id="defs8">
  <style type="text/css" id="current-color-scheme">
   .ColorScheme-Text { color:#5c616c; } .ColorScheme-Highlight { color:#5294e2; } .ColorScheme-ButtonBackground { color:#d3dae3; }
  </style>
 </defs>
 <path style="fill:currentColor" d="m7 3-5 3 4 2.9844-4.0098 3.0076 5.0098 3.008 4-3-5-3 5-3 5 3.0156-5 2.9844l4 3 5.0098-3.0234-4.01-2.98 4-3-5-3-4 2.9844-4-2.9844zm4 10-4 3-1-0.6v0.6l5 3 5-3v-0.604l-1 0.604-4-3z" id="path4" class="ColorScheme-ButtonBackground"/>
</svg>

use color class ColorScheme-ButtonBackground { color:#d3dae3; } - it's light icon! NonKDE apps not apply KDE color scheme from button background, because it's impossible. All nonKDE apps appply color from icon theme only. Maybe it's cache problem?

nicodorn commented 7 years ago

As I said: Unfortunately, all those tricks didn't help for me. I did a bunch of logouts, logins, deleting of KDE's icon cache … without any effort. As I saw that Papirus-Dark always takes the right icons (at least for the tray) I copied them--as I wrote in my previous post. I'm fine now.

By the way: The Dropbox icon wasn't the only one I had problems with. I think every icon in the tray that grapped an alternative in Papirus was affected. The update icon was all dark, too.

varlesh commented 7 years ago

it's impossible! Open icon theme folder and check colors for panel icons... i don't know why this happened on your system:

abouvier commented 7 years ago

This problem is not really fixed :p And it's probably not related to Hardcode-Tray because I have a native icon who is dark instead of being white: screenshot_20170328_055005 It's the update notifier from the discover package.

abouvier commented 7 years ago

Another one is the microphone icon on the volume control applet: screenshot_20170421_181204

SmartFinn commented 7 years ago

@abouvier it isn't Papirus icon.

abouvier commented 7 years ago

Yes it is, it's the microphone-sensitivity-medium.svg or microphone-sensitivity-medium-symbolic.svg.

SmartFinn commented 7 years ago

Oops, yeah. Anyway microphone-sensitivity-medium.svg has the same CSS stylesheet as audio-volume-high-panel.svg. So I don't know why it happens. I can't reproduce this bug on my virtual machine.

varlesh commented 7 years ago

fixed https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/commit/e58810d0369b1a36b5e273a2b61c47fbb543ddf0