search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.65k stars 423 forks source link

[Icon request] Turn thunar icon back to folder icon instead of Thunar hammer #2555

Closed coreybruce closed 3 years ago

coreybruce commented 3 years ago

I noticed there was a update for the Papirus icon theme and I noticed that Thunar’s icon was changed from the folder icon to the Thunar hammer icon and wanted to suggest/ask if it could be changed back to the folder icon as it now just looks ugly and out of place and would confuse users if their file manager icon changed from the known file manager icon to the Thunar hammer icon. It would keep the icon theme more consistent and just over all look better.

To be more consistent, if you were using papirus dark than thunar should use the blue folder icon

varlesh commented 3 years ago

For XFCE updated more icons, not Thunar only. Parole, Ristretto, Mousepad updated too. Also added icons for other FM's (that not used system-file-manager) - Nautilus, Nemo. Not seen reason revert icon. Original old icon: image New version: image our version: image

coreybruce commented 3 years ago

I understand it wasn't the only icons updated but I am specifically looking at Thunars as it looks really out of place to the other folder icons

coreybruce commented 3 years ago

For example if your using Papirus-Dark it would look a lot better if file managers stuck with the consistency of the theme and used the generic folder icon.

folder_doc_q4os_startmenu

This would also be the same with the other Papirus themes like Papirus-Dark-Mia with the green folder icon

folder1

What I am trying to make a point about is it would look cleaner and more uniform by using the folder or file manager icon for file managers. I really like this theme and love it's clean icons and just wanted to suggest it. :)

coreybruce commented 3 years ago

Here is a visual representation of what I mean :smiley:

Screenshot_1 Screenshot_2

maxtron95 commented 3 years ago

I'd say, how about a compromise?

thunar-folder

coreybruce commented 3 years ago

That would work but it would depend on the icon theme version, would work better if it was blue to keep consistency :)

varlesh commented 3 years ago

Nope guys. Folder it's not file manager! Folder it's folder. We present other icons for file managers, it's advisable if you use multiple file managers on system. How to distinguish between icons, if all FM's used only system-file-manager icon only?

@coreybruce Sorry i'm not seen reason open this again. We reproduce original icon, as how could

varlesh commented 3 years ago

folder-blue broken papirus-folders and our idea. We not use folder icon for file managers!!! I'm really not seen problem for this. We use original icons style by XFCE

varlesh commented 3 years ago

Yes, a habit is a tricky thing... But now i can install nautilus & thunar - icons different, i can discern that

varlesh commented 3 years ago

This very hard solution... Why if use icons Nautilus, why not for Thunr? Thunar worse or what? I like system-file-manager icon. I like it too!!! But Thunar not use that! Thunar use Thunar icon name (or org.xfce.thunar). Why i'm need replace original Thunar icon to system-file-manager? I think, it's only your desire

no offense ))

coreybruce commented 3 years ago

I mean that is what every OS and other icon themes on Linux use. Even with Nautilus the icon makes sense with a file manager icon.

Windows 10: image

Mac OS uses the finder icon but it doesn't look out of place but also uses folder icons: image

Android uses folder icons for the file manager with different variations depending on if it's a stock or custom theme. image

even if it was a file manager icon instead of a folder icon I was just using the folder as a example but it would still look much better than thunars hammer icon and had a file manager or folder icon.

maxtron95 commented 3 years ago

I'm not sure, but I think a fork would be feasible at this point. @coreybruce

varlesh commented 3 years ago

@coreybruce We present file manager icon, as system-file-manager This icon not changed and available! But Thunar used icon Thunar and i'm reproduce their icon on Material syle

varlesh commented 3 years ago

even if it was a file manager icon instead of a folder icon I was just using the folder as a example but it would still look much better than thunars hammer icon and had a file manager or folder icon.

you can create custom desktop-file for Thunar with folder-blue icons. It's your opinion. Or fork & replace our icons. We opensource project & we have no reason to object to you

It's closed!!! welcome to PR

maxtron95 commented 3 years ago

even if it was a file manager icon instead of a folder icon I was just using the folder as a example but it would still look much better than thunars hammer icon and had a file manager or folder icon.

you can create custom desktop-file for Thunar with folder-blue icons. It's your opinion. Or fork & replace our icons. We opensource project & we have no reason to object to you

It's closed!!! welcome to PR

The magic of open-source, anyone can fork or make PRs to their liking. That was how many linux distros were born.

varlesh commented 3 years ago

yes, you are right @creepertron95 File Manager it's FM, Text Editor -it's only Text Editor.... But users forget that, when icon theme used on other DE's, when your theme support multiple DE's IMHO ))

datenstau commented 3 years ago

What happened to the Nautilus Icon? Now it's some ugly blue file drawer instead of the known folder icon.

varlesh commented 3 years ago

@datenstau If you haven't noticed, other GNOME/XFCE/KDE icons have been added too. GEdit, Kate, Mousepad, EOG, Ristretto, GwenView and etc... Why i must doing exeption for file managers? If you use multiple file managers on system - it's confused you

Original icon: image Our icon: image

Anyway system-file-managernot removed or changed, you can use this icon if you want with custom desktop-file

varlesh commented 3 years ago

It's Nautilus devs decide use original icon instead system-file-manager. See this commit: https://gitlab.gnome.org/GNOME/nautilus/-/commit/eff30bcf53daa6f90c70dfb7c495244a3bd612aa And Thunar too: https://gitlab.xfce.org/xfce/thunar/-/commit/78f73f668c090e590b6492ed9be781e2907b4db6

But not all FM's used that: https://github.com/KDE/dolphin/blob/master/src/org.kde.dolphin.desktop#L53 https://github.com/lxqt/pcmanfm-qt/blob/master/pcmanfm/pcmanfm-qt.desktop.in#L5 https://github.com/elementary/files/blob/master/data/io.elementary.files.desktop.in.in#L8 https://github.com/mate-desktop/caja/blob/master/data/caja-browser.desktop.in.in#L8 https://github.com/linuxmint/nemo/blob/master/data/nemo.desktop.in#L100

varlesh commented 3 years ago

@datenstau @coreybruce @creepertron95 @miascugh @GavinAndre @Mpc46 @SmartFinn as exeption we revert Nautilus, Thunar, Nemo & Dolphin to symlink system-file-manager closed!