New file manager icon not kept in while reverting as mentioned

owzim commented 3 years ago

It is said that while reverting to the old file manager icon, the new one is kept for custom desktop files. But it is not true, the original file also got reverted

comment: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/2555#issuecomment-778592966

see:

https://raw.githubusercontent.com/PapirusDevelopmentTeam/papirus-icon-theme/master/Papirus/32x32/apps/system-file-manager.svg https://raw.githubusercontent.com/PapirusDevelopmentTeam/papirus-icon-theme/master/Papirus/64x64/apps/system-file-manager.svg

Jump to the solution ▼

SmartFinn commented 3 years ago

I don't clearly understand what is the issue about. What do you expect? Did you want to use the individual icons for a file manager?

owzim commented 3 years ago

@SmartFinn thanks for the reply.

A couple of days ago, Nemo had this new beautiful blue icon:

now it s a back to this:

What happened?

This comment https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/2555#issuecomment-778592966 states, that the new actual icon was not reverted and available as system-file-manager for people who want to use it in custom desktop files. But that's not true. The new pretty icon is not to be found under the name system-file-manager on current master.

SmartFinn commented 3 years ago

@owzim seems you misunderstood the comment, it describes how to change the blue Nautilus icon to classic system-file-manager, but not otherwise.

After the revert the blue Nautilus icon was removed. Unfortunately, we cannot keep both icons because the icon names the same. So we decided to restore the old behavior, i.e. system-file-manager for almost all file managers.

owzim commented 3 years ago

@SmartFinn thanks for the clarification. So the new blue one was ditched? Why was it reverted?

SmartFinn commented 3 years ago

@owzim because of negative user reactions (see https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/commit/5bb27340a28ffb967206d5d9920a750790292cdf#commitcomment-46665663 and #2555) and because of a couple of minor issues with the icon.

owzim commented 3 years ago

@SmartFinn I see only a couple (3) of people complaining and they're not even referring to nautilus (on which original adwaita icon this new one is based, ... and suited). I bet there a many times more people welcoming the change, without being vocal. Would you consider putting back in the blue one for only nautilus at least?

SmartFinn commented 3 years ago

@owzim

I bet there a many times more people welcoming the change, without being vocal.

I don't think so.

Would you consider putting back in the blue one for only nautilus at least?

No. Too hard to make the icon close to the upstream one due to differences in style. This blue icon looks very poor on a vertical panel. So we wouldn't keep it as it is anyway.

varlesh commented 3 years ago

@owzim Discuss this thread with @datenstau @coreybruce @miascugh @GavinAndre @Mpc46 We surrendered ))

marcelovbcfilho commented 3 years ago

I'm with @owzim man the new Nautilus icon was so beautiful, I'm so sad that now he is gone, I'll probably revert back to that commit...

verssales commented 3 years ago

You took my heart 108508757-91c5a780-72bc-11eb-93d0-5cd8025381f9 and break it in front of me 😭 108508917-d5b8ac80-72bc-11eb-84a9-d244cea37537 Please revert to the blue one 😁

coreybruce commented 3 years ago

See a lot of people agree with me, I even ask average users and they agree when they see a icon and want to access their files they look for the folder icon plus it will be consistent with the icon theme. going back to my report I put in and was ignored even tho I showed plenty of examples where it made sense here

https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/2555?notification_referrer_id=MDE4Ok5vdGlmaWNhdGlvblRocmVhZDE1NzAzMDI5NTY6ODM5Mzc4MA%3D%3D#issuecomment-781475841

gregorydk commented 3 years ago

I'm with @owzim man the new Nautilus icon was so beautiful, I'm so sad that now he is gone, I'll probably revert back to that commit...

Yes, I"m sad too. I really liked the blue icon and thought it looked great.

I think papirus icons should stay as close as possible to the apps original version, but with material style. When people switch from original icons to papirus icons at least the icons look similar and don't confuse the user.

I'm also sure some developers don't like to see a completely different icon for their app.

SmartFinn commented 3 years ago

I think papirus icons should stay as close as possible to the apps original version, but with material style. When people switch from original icons to papirus icons at least the icons look similar and don't confuse the user.

Even if it breaks user experience, like in the case with Thunar?

marcelovbcfilho commented 3 years ago

I think papirus icons should stay as close as possible to the apps original version, but with material style. When people switch from original icons to papirus icons at least the icons look similar and don't confuse the user.

Even if it breaks user experience, like in the case with Thunar? But why we can't in the Thunar keep the old one ? And update the nautilus, I understand that the Thunar is not very friendly so, in that case use the old one for user experience purpose.

SmartFinn commented 3 years ago

But why we can't in the Thunar keep the old one ? And update the nautilus, I understand that the Thunar is not very friendly so, in that case use the old one for user experience purpose.

https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/2567#issuecomment-782087054

SmartFinn commented 3 years ago

This is what the revised version (b9d27b1aa2ccb73f032819116ca3ec55a447acd0) of Nautilus icon looks like, but it is still thinner than the others. That's why we decided to revert the system-file-manager and do not make exceptions for the Naultilus.

marcelovbcfilho commented 3 years ago

This is what the revised version (b9d27b1) of Nautilus icon looks like, but it is still thinner than the others. That's why we decided to revert the system-file-manager and do not make exceptions for the Naultilus.

I still believe that even it being thinner it is still pretty good, this will help the keep some of the gnome look and feel.

SmartFinn commented 3 years ago

this will help the keep some of the gnome look and feel

Hm.., I always thought users install the custom themes to change the default look and feel instead of keeping it. Anyway, the gnome look and feel is not a goal of Papirus icon theme.

varlesh commented 3 years ago

@gregorydk Yes, but not all. Some original icons hard draw with material style or don't like us.

All file managers have your icon. Dolphin system-file-manager Nautilus org.gnome.Nautilus Thunar org.xfce.thunar Nemo system-file-manager Files system-file-manager

But not all FM's used new rDNS standard icon names. We can't draw system-file-manager for all file managers and match their style - it's impossible. We can't make system-file-manager as folder, because it's broken papirus-folders & our HIG. Folder it's folder. We not create icon theme ONLY for GNOME or XFCE or KDE & etc... This theme support all modern DE's!

Maybe as solution added reverted icon as altternative icons, for example org.gnome.Nautilus & org.xfce.thunar symlink to system-file-manager. Reverted icons use nautilus & thunar icon names. (Similar solution earlier was with Firefox, but removed on the feature) Anyway it's not good solution & don't like me.

I don't know how solve this problem. Some users like new icons for Nautilus & Thunar, some users don't like.

coreybruce commented 3 years ago

Can someone look at my issue and agree that this post is similar with the addition of just wanting to improve the theme and keep consistency?

marcelovbcfilho commented 3 years ago

But not all FM's used new rDNS standard icon names. We can't draw system-file-manager for all file managers and match their style - it's impossible. We can't make system-file-manager as folder, because it's broken papirus-folders & our HIG. Folder it's folder. We not create icon theme ONLY for GNOME or XFCE or KDE & etc... This theme support all modern DE's!

Maybe as solution added reverted icon as altternative icons, for example org.gnome.Nautilus & org.xfce.thunar symlink to system-file-manager. Reverted icons use nautilus & thunar icon names. (Similar solution earlier was with Firefox, but removed on the feature) Anyway it's not good solution & don't like me.

I don't know how solve this problem. Some users like new icons for Nautilus & Thunar, some users don't like.

How i was saying, I liked the new one, but if the goal of papirus team is to create a UNIQUE design this kind of discussion shouldn't be considered, because isn't a team goal. A best discussion would be how to improve the current papirus file manager icon and not how to make it more like the DE file manager original icon

varlesh commented 3 years ago

folder icon as system-file-manager broken papirus-folders idea. Yes, we can symlink system-file-manager to user-blue-home all fine, when you change color to green will be used green folder & system-file-manager. BUT it's broken other tools Folder Color or Dolphin Folder Color, becuase this tools worked with another way.

varlesh commented 3 years ago

best solution for this - neutral color. It's grey (now used partially) we will get a faded color and featureless icon

varlesh commented 3 years ago

symlink system-file-manager to user-blue-home solved mostly problems... But we lost support Folder Color or Dolphin Folder Color With papirus-folders util you can set any color for folders & system-file-manager @SmartFinn What you think?

SmartFinn commented 3 years ago

symlink system-file-manager to user-blue-home solved mostly problems...

This not solve any issues. Neither a unique icon for each file manager nor make the system-file-manager icon close to the upstream one. Well, users can make this change themselves by editing a desktop file.

A best discussion would be how to improve the current papirus file manager icon

I don't see any issues with the current system-file-manager icon.

GavinAndre commented 3 years ago

@owzim

I bet there a many times more people welcoming the change, without being vocal.

I don't think so.

Would you consider putting back in the blue one for only nautilus at least?

No. Too hard to make the icon close to the upstream one due to differences in style. This blue icon looks very poor on a vertical panel. So we wouldn't keep it as it is anyway.

I agree with you. The blue icon looks very poor on a vertical panel and Manjaro looks broken.

Screenshot from 2021-02-22 09-23-26

GavinAndre commented 3 years ago

@owzim Discuss this thread with @datenstau @coreybruce @miascugh @GavinAndre @Mpc46 We surrendered ))

The system-file-manager icon looks so pretty that many people don’t want to change it like me.

KardinalReusen commented 3 years ago

It's really sad that the beautiful new blue icon is gone and the boring grey drawer is back.

coreybruce commented 3 years ago

Yeah the grey one just sticks out like a sore thumb with the rest of the theme and isn't consistent yet sadly the developer won't budge even if it makes sense to use the blue folder icon with the rest of the theme that uses it..

sowrensen commented 3 years ago

This is a shame that the icon reverted back to the old grayish one. Loved the blue icon. I am shocked to see less appreciation for things that are nice.

gregorydk commented 3 years ago

Ideally, system-file-manager is the grey or whatever icon and Nautilus and Thunar is respectively a blue and a hammer icon. If Nautilus and Thunar would have wanted a generic icon, they would have named it system-file-manager, but they didn't.

What the icon should never be is a folder because a file manager is not a folder.

varlesh commented 3 years ago

@gregorydk This issue solved, closed

KardinalReusen commented 3 years ago

Ideally, system-file-manager is the grey or whatever icon and Nautilus and Thunar is respectively a blue and a hammer icon. If Nautilus and Thunar would have wanted a generic icon, they would have named it system-file-manager, but they didn't.

What the icon should never be is a folder because a file manager is not a folder.

I use Budgie Desktop whitch uses Nautilus File Manager. The icon is generic grey instead of blue.

varlesh commented 3 years ago

@KardinalReusen Sorry, but other users don't like blue Nautilus icon...

varlesh commented 3 years ago

added alternate Nautilus & Thunar icons: nautilus nautilus-alt thunar

SmartFinn commented 3 years ago

To use these icons run the following commands in the terminal, then log out and then log back in again to take effect if this required.

GNOME Files / Nautilus

desktop-file-install --dir ~/.local/share/applications --set-icon=nautilus /usr/share/applications/org.gnome.Nautilus.desktop

desktop-file-install --dir ~/.local/share/applications --set-icon=nautilus-alt /usr/share/applications/org.gnome.Nautilus.desktop

Xfce Thunar

desktop-file-install --dir ~/.local/share/applications --set-icon=thunar /usr/share/applications/thunar.desktop

for Xfce lower than 4.16:

desktop-file-install --dir ~/.local/share/applications --set-icon=thunar /usr/share/applications/Thunar.desktop

PapirusDevelopmentTeam / papirus-icon-theme