search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.53k stars 414 forks source link

Wrong xfce4-power-manager tray icon color #2615

Open aacebedo opened 3 years ago

aacebedo commented 3 years ago

I use the vimix-dark-laptop-ruby theme and the PapirusDark theme. The icon of the tray despite being white on my disk is recolored to a dark color, making it invisible. I checked with strace xfce4-power-manager that the icon loaded is correct /usr/share/icons/Papirus-Dark/symbolic/status/battery-level-80-symbolic.svg But it is displayed in a dark color: xfce4-power-manager

The only way to fix this is to add * {color:#FFFFFF;} to ~/.local/gtk-3.0/gtk.css however it has impact on other places than this specific icon

varlesh commented 3 years ago

https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/2484

aacebedo commented 3 years ago

I don't think that's the same as #2484, the icon is correctly found and displayed but with the wrong styling. Do you think it is related to the gtk theme or the application instead of the icons theme ?

varlesh commented 3 years ago

Papirus - it's Darker theme, but symbolic icons need get color from GTK theme. This icon not get color from GTK Theme...

varlesh commented 3 years ago

@aacebedo what this orange icon on tray? And why wifi icon very small?

aacebedo commented 3 years ago

what this orange icon on tray? And why wifi icon very small?

The orange icon is the seafile application (www.seafile.com). The wifi is small because I was missing a bar in reception quality (if you zoom you can see the darker background), so it's working correctly.

Ok so even if I see that the battery icon color is correct in Papirus-Dark, it's color shall have been changed by the theme to match the dark theme ? In this case I shall create an issue on the vmix theme.

varlesh commented 3 years ago

On Papirus Dark used only light symbolic icons, you can check it... But it's irrelevant, symbolic colors draw from GTK

aacebedo commented 3 years ago

Ok thank you, I'll do an issue on the GTK theme, maybe there is something wrong with xfce4-power-manager.

varlesh commented 3 years ago

seafile icons used from binary qrc: https://github.com/haiwen/seafile-client/blob/master/src/ui/tray-icon.cpp#L492

aacebedo commented 3 years ago

seafile icons used from binary qrc: https://github.com/haiwen/seafile-client/blob/master/src/ui/tray-icon.cpp#L492

You are right, I did not noticed the seafile icon because it was readable on my theme, They shall probably rewrite that to use a theme provided icon or at least a svg icon to let the theme recolorize it I guess.

varlesh commented 3 years ago

I'm now test manjaro xfce 4.16 and battery icon show correct... BUT i'm not have battery have only stationary computer). image image I think it's upstream xfce4-power-manager bug. Also only battery icons used symbolic style... All other tray elements not symbolic

varlesh commented 3 years ago

See last screen all icons used color #444444, but battery use from GTK Theme #323232

aacebedo commented 3 years ago

What's your gtk theme ? I guess I shall be able to display then correct icon like you even if it is not the exact color. My version of xfce4-power-manager seems to be the same as you. Note I use polybar for the tray icon zone.

aacebedo commented 3 years ago

Do you think the bug shall be reopened to keep track of this ?

varlesh commented 3 years ago

It's built in Manjaro XFCE Themes... I think better way for you - found another power manager applet for battery, with libappindicator for example

varlesh commented 3 years ago

https://github.com/maateen/battery-monitor

aacebedo commented 3 years ago

https://github.com/maateen/battery-monitor

Thank you for the info but I prefer not to use unmaintained projects so I'll stick with the xfce4-power-manager if there is nothing else for moment. I hope the bug will be fixed. I notified vimix theme project of the issue. Maybe they'll find then correct css selector to add to target only this application.

renyhp commented 1 year ago

I managed to customize this color: you can use

#xfce4-power-manager-plugin image {
  -gtk-icon-palette: warning #ff0000, success #00ff00, error #0000ff;
  color: #ffff00;
}

Of course you can change your colors here. color is for "normal" status, warning is for "caution", success is for full/charging, and error is for empty battery.

MrHappy commented 1 year ago

I managed to customize this color: you can use

#xfce4-power-manager-plugin image {
  -gtk-icon-palette: warning #ff0000, success #00ff00, error #0000ff;
  color: #ffff00;
}

Of course you can change your colors here. color is for "normal" status, warning is for "caution", success is for full/charging, and error is for empty battery.

I'm pretty new with this, but can you tell me where to change/add this? Adding it to ~/.config/gtk-3.0/gtk.css and restarting the power-panel changes nothing...