search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.54k stars 414 forks source link

Clearly separate icons of nonfree software #2636

Open throwaway1037 opened 3 years ago

throwaway1037 commented 3 years ago

Whilst the icons are technically free, some depict proprietary software, or trademarks.

These need to be clearly separated from the rest to ensure the users can be fully free and only choose to install the icons depicting free software with no trademarks.

SmartFinn commented 3 years ago

This is not an easy task, it is not feasible within this repository. If someone wants to moderate a fork under this organization - welcome.

throwaway1037 commented 3 years ago

I suppose a good way to do this would be to either make a big JSON metadata file containing keys like free-software, proprietary-software, or trademark, or have separate folders for each.

SmartFinn commented 3 years ago

Even if you separate them, you will not be able to delete a certain group because of symlinks. The easiest way is to delete all non-free icons.

throwaway1037 commented 3 years ago

Would three separate repos be a good idea?

  1. Papirus papirus-icon-theme-all (contains all icons; essentially this repo, but renamed and using git submodule to include the following two repos)
  2. Papirus-libre papirus-icon-theme-libre (contains only icons of free software with no trademarks)
  3. Papirus-proprietary papirus-icon-theme-proprietary (contains only icons of nonfree software and trademarks)
SmartFinn commented 3 years ago

That is no sound like a good idea because it hell hard to maintain. The one separated papirus-icon-theme-libre repo with pre-moderation is better.

varlesh commented 3 years ago

@throwaway1037 How you want analize more 7k apps? You have trademark database or want ask all apps-developer about logo, trademark, politics, license and etc? 7k apps it's only apps/48px, but also we have 16/22/24/32/64 and tray icons 16/22/24...

Also we not alone, who used trademarks logos on icon theme. For example Breeze: https://github.com/KDE/breeze-icons/blob/work/breeze_icons_library/icons/actions/16/im-yahoo.svg https://github.com/KDE/breeze-icons/blob/work/breeze_icons_library/icons/actions/16/im-youtube.svg https://github.com/KDE/breeze-icons/blob/work/breeze_icons_library/icons/actions/16/im-twitter.svg https://github.com/KDE/breeze-icons/blob/work/breeze_icons_library/icons/actions/16/im-skype.svg https://github.com/KDE/breeze-icons/blob/work/breeze_icons_library/icons/actions/16/im-facebook.svg https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/tree/master/data/icons/symbolic

throwaway1037 commented 3 years ago

I am aware of this issue amongst icon themes. I thought I'd first ask Papirus because it's my favourite!

I think for now this is something to do in the future and will take a while to complete the audit.

varlesh commented 3 years ago

@throwaway1037 We are interested in whether you represent a free/comercial company or are you an individual?

throwaway1037 commented 3 years ago

I'm an individual who cares about free software and free culture. To clarify and settle any fears you might have: I do not represent any entities with trademarks.

varlesh commented 3 years ago

Ok. Complete audit all Papirus files - it's very very very giant work... I don't know how doing this... There are many pitfalls. I don't like idea

papirus-icon-theme-libre (contains only icons of free software with no trademarks)

Because some free-apps used trademarks, for example Firefox or Fedora

I hink better solution for us - use only system icons without any all 3d-party apps (non-free & free too)

varlesh commented 3 years ago

Also initial Papirus project born as icon theme for KDE, because Paper icon theme at that time did not support KDE-apps... But later we added support more other DE's. And some files initially have wrong non-freedesktop standard name. For example icon utilities-file-archiver it's symlink to KDE archive manager ark. If we remove all 3-d party icons, ark will be removed and symlink will be broken. It's only one problem, but there may be hundreds

luisrguerra commented 3 years ago

You could create a separate theme called Papirus Lite with the most important Linux icons and add an inheritance to Papirus from Papirus Lite. This could perhaps make development easier after the laborious task of reorganizing the theme.

maxtron95 commented 3 years ago

You could create a separate theme called Papirus Lite with the most important Linux icons and add an inheritance to Papirus from Papirus Lite. This could perhaps make development easier after the laborious task of reorganizing the theme.

Do you mean a separate theme removing all but keeping only the system-critical icons, like Elementary-XFCE or Adwaita?

I am aware of this issue amongst icon themes. I thought I'd first ask Papirus because it's my favourite!

I think for now this is something to do in the future and will take a while to complete the audit.

Probably want to check the default Icon theme of Linux Mint as well.

How you want analize more 7k apps? You have trademark database or want ask all apps-developer about logo, trademark, politics, license and etc?

7k apps it's only apps/48px, but also we have 16/22/24/32/64 and tray icons 16/22/24...

Not just applications, but I think this also applies to mimetypes and folders as well.

darkshram commented 3 years ago

@creepertron95 Numix does something similar with their icon sets. Numix-icon-theme only provides general UI icons and does not include any application icon as policy. Numix-icon-theme-circle and numix-icon-theme-square provide the application icons.

varlesh commented 3 years ago

Not just applications, but I think this also applies to mimetypes and folders as well.

Oh, yes. We have more files))

@darkshram We can't reorgnize our repo like as Numix structure. It's very hard work. All scripts will be broken. All symlinks will be broken. Need rewrite ALL!!!

varlesh commented 3 years ago

Papirus folder contained 73113 files now. Who want audit 73K files?

SmartFinn commented 3 years ago

@throwaway1037

I suppose a good way to do this would be to either make a big JSON metadata file containing keys like free-software, proprietary-software, or trademark, or have separate folders for each.

Do you request a possibility to choose the categories before installation or a separate JSON file with the info is enough?

varlesh commented 3 years ago

Why Papirus popular? Because contained mostly 3-d party apps, because support hardcode-tray, because support folder colors, because present icons with differrent sizes, because use HIG for icons and etc, because i like it? It's unknown.

@throwaway1037 II'm not against if you want create very clean and absolute free Papirus icon theme. But we can't doing this. We can't audit more thousand files. Also our files present as source XML-files, it's not icons formally.

We are ready to solve the problem if it is in our power

luisrguerra commented 3 years ago

You could create a separate theme called Papirus Lite with the most important Linux icons and add an inheritance to Papirus from Papirus Lite. This could perhaps make development easier after the laborious task of reorganizing the theme.

Or create a separeted theme named "Papirus+" and starting to add the new third party apps (ex: games) at "Papirus+", adding an inheritance from "normal" Papirus theme. This way you could gradually move "non critical system icons" to Papirus+ and simplify the "core" papirus theme for a easier development.