PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.47k stars 410 forks source link

electron-mail tray icon is not using the typical tray color #3076

Closed PoisonFrog closed 2 years ago

PoisonFrog commented 2 years ago

Why the electron-mail tray icon is green and not using the #DFDFDF color that all the other icons use? This looks like a mistake. I remember in old versions of Papirus it had the right color.

Btw, I just realized that the attention icon is also missing now. If I'm not mistaken Papirus used to have the attention version too.

varlesh commented 2 years ago

This exception only for hardcode-tray and does not break the program logic. Our icons have perfect pixel align for 16/22/24px tray icons. You can choose colors on application settings. With Papirus colors it's can be #dfdfdf/#444444 and notification color #4285f4

61171195-e3546f00-a57c-11e9-9efe-415b7bdcdc38

https://github.com/vladimiry/ElectronMail/issues/464

vladimiry commented 2 years ago

Our icons have perfect pixel align for 16/22/24px tray icons.

Btw, the app supports custom tray icon size since https://github.com/vladimiry/ElectronMail/releases/tag/v4.15.0

PoisonFrog commented 2 years ago

Our icons have perfect pixel align for 16/22/24px tray icons.

Btw, the app supports custom tray icon size since https://github.com/vladimiry/ElectronMail/releases/tag/v4.15.0

I just think it looked way better when Papirus was handling the electron-mail icons. Now it looks okay when there is no notifications but once you get a notification it doesn't look right among other Papirus icons in the panel because the notification dot is way bigger. I don't get why it was changed to let electron-mail handle it.

varlesh commented 2 years ago

@PoisonFrog I believe that the developer should be thanked for the work done, and not criticized (this is my personal opinion). The developer tries as best he can, unlike others who can sew the icon into a binary file. You have the usual color, notification color, size. The Papirus team has added support for pixel alignment (with hardcode-tray) and respects the author's decision.

PoisonFrog commented 2 years ago

@varlesh I'm not criticizing the developer, the tool is great but I think it suits better people that are not using an icon theme. When I'm using an icon theme like Papirus I want consistency among all the icons and from a consistency standpoint it was better before the changes. You have many options now but none of them makes it look exactly like other Papirus icons when the notification dot is showing.

varlesh commented 2 years ago

Badge is drawn from code, the icon theme (or hardcode-tray) cannot fix it. Many users want to see the number of messages when notified. And this is hardly possible with a small dot. Maybe author found better solution

PoisonFrog commented 2 years ago

Badge is drawn from code, the icon theme (or hardcode-tray) cannot fix it. Many users want to see the number of messages when notified. And this is hardly possible with a small dot. Maybe author found better solution

If I'm not mistaken Telegram can also show the number of unread messages yet the Papirus Theme replaces the Telegram icon. I do prefer it that way. In my opinion if users want the native icon and its extra features they don't need to apply an icon theme then. I just think it is weird that the previous Papirus icons for electron-mail were removed in favor of the new one just so the people that want the message counter can have the icon in the right size yet these people don't care that the notification dot size doesn't match the rest of the theme. Couldn't they just use the native icon without applying hardcode-tray for electron-mail and change the icon color in the setttings if they don't care that much about consistency? That way us that do care could still have the old icons that fit perfectly with the rest of the theme.

Anyways, this is not a big deal. I can live with it. The only reason why I opened this issue was because I thought this was a mistake and not a decision taken by Papirus devs. If I knew this was intentional I would not open the issue.

varlesh commented 2 years ago

If I'm not mistaken Telegram can also show the number of unread messages yet the Papirus Theme replaces the Telegram icon. I do prefer it that way. In my opinion if users want the native icon and its extra features they don't need to apply an icon theme then. I just think it is weird that the previous Papirus icons for electron-mail were removed in favor of the new one just so the people that want the message counter can have the icon in the right size yet these people don't care that the notification dot size doesn't match the rest of the theme. Couldn't they just use the native icon without applying hardcode-tray for electron-mail and change the icon color in the setttings if they don't care that much about consistency? That way us that do care could still have the old icons that fit perfectly with the rest of the theme.

Ough ))) We struggled with the Telegram for a long time, in the end we managed to persuade them. First there were environment variables, then they canceled everything, then they returned again, but with a counter. In the end, everything was solved successfully.

@vladimiry Perhaps as a solution. If the "Don't render the value" option is enabled, application use a static notification icon. Because, a large badge looks strange without a counter. But what to do with the colors? I do not know... After all, the notification icon must support two colors, at least. It's hard for me to imagine how this is possible to implement.

PoisonFrog commented 2 years ago

@vladimiry Perhaps as a solution. If the "Don't render the value" option is enabled, application use a static notification icon. Because, a large badge looks strange without a counter. But what to do with the colors? I do not know... After all, the notification icon must support two colors, at least. It's hard for me to imagine how this is possible to implement.

I honestly do not think this is that much of an issue. Most people will not be bothered with the notification dot being bigger, it is just a pet peeve of mine. It's not worth the extra work imho.

varlesh commented 2 years ago

@PoisonFrog The whole problem is in the counter. Someone needs it, and someone does not. It is difficult to find a compromise here.

varlesh commented 2 years ago

My thoughts are only. The tray has a very small space and the implementation of the counter in it seems unnecessary to me. It is very difficult to distinguish the numbers in such a small size. And also to make it all look harmonious in all OS and DE ... Usually the application panel or dock takes over this idea. Here, for example, Latte Dock and Discord: image image

varlesh commented 2 years ago

I don't know how this is implemented on Gnome panel or Plank, Windows taskbar or Mac OS. But it simplifies perception.

varlesh commented 2 years ago

In any case, we can only offer some options, and even better PR's)). But only the developer decides how to properly and what should be sacrificed.