search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.48k stars 412 forks source link

Name of Star Trek icon #3327

Closed Bernmeister closed 1 year ago

Bernmeister commented 1 year ago

I'm using Lubuntu 20.04 and 22.04 and installed my appindicator which contains an SVG icon called indicator-stardate.svg.

I noticed my icon does not display, but another similarly looking icon with a background circle shadow. The icon is present in the Paprius directory (including the Light and Dark variants), but named indicator-stardate.svg.

Is this icon (with background circle shadow) part of the Papirus theme and if so, what is it's name please? If I can identify the icon, then I can ask over at the Lubuntu forum if they understand what is happening...

EDIT: I have subsequently discovered more icons created for my indicators, namely Fortune, Lunar and VirtualBox™.

SmartFinn commented 1 year ago

Sorry, I don't clearly understand what the issue about. indicator-stardate.svg with background circle is a part of Papirus icon theme that added to adapt icon for your appindicator to our sizes and colors.

Bernmeister commented 1 year ago

@SmartFinn Thank you for confirming the situation. I was surprised to see alternate icons appear on a clean installation of Lubuntu and my appindicator(s) which is why I raised the issue (initially believing the issue was with Lubuntu itself).

I'd prefer the appindicators use the correct icons (those which come with the corresponding appindicator itself). If an alternate colour/size is required, I am happy to make that change within the appindicators.

SmartFinn commented 1 year ago

@Bernmeister so, do you ask to remove the icons of your appindicator from the icon theme?

Bernmeister commented 1 year ago

@SmartFinn I am not asking you to remove your icons from your theme, as you are free to make any icons you choose and your icons are your work. The situation here is that the icons which come with my appindicators are being overwritten by icons which are not mine and although look somewhat similar, are different.

I looked at my source code and realised that since I originally created this issue I went ahead and provided icons for ePapirus, Papirus and Papirus-Light (by adding to my build script the colours ffffff, dfdfdf and 444444 respectively). If any of those colours are incorrect, please let me know and I will make the necessary adjustments (and similarly for sizes or other themes).

SmartFinn commented 1 year ago

@Bernmeister Do you want to override the icon because the icon theme overrides the icon? Sounds like nonsense to me. There are two options to avoid overriding an overridden icon:

  1. remove the icon from the icon theme
  2. update the icon in the icon theme to match original one

I preferred the second, as more rational.

Bernmeister commented 1 year ago
  1. remove the icon from the icon theme
  2. update the icon in the icon theme to match original one

I preferred the second, as more rational.

From where did you obtain the originals? What about the sizes you mentioned earlier that were missing? I see you replaced the icon for indicator-stardate but what about the other indicators I listed above? I actually made changes to all my icons a few months ago, requiring a full release; in that event do I need to open a new ticket here?

SmartFinn commented 1 year ago

@Bernmeister

From where did you obtain the originals?

I saw your icons in archives hosted on Launchpad.

Creating small pictograms is not an easy task and is full of compromises. Icons should be visually no larger than others, have no small details (that smaller than 1px), and have clear edges that match the physical pixels on the screen. At the same time, have a common style with other icons. That's why icons can't be clones of the originals.

What about the sizes you mentioned earlier that were missing?

All the needed sizes already in the repo.

I see you replaced the icon for indicator-stardate but what about the other indicators I listed above?

Why we should replace it? If you want to prevent your indicators from being themed, just ask. This will allow us to reject icon requests from your users, who will see big blurred icons that out of style.

Bernmeister commented 1 year ago

Why we should replace it? If you want to prevent your indicators from being themed, just ask. This will allow us to reject icon requests from your users, who will see big blurred icons that out of style.

I wasn't aware there were requests for some/all of my appindicator icons to be replaced. Could you please point me to those (assuming they are tickets/issues).

As I have created what I believe are correct colours for your theme and are part of the indicators since December 2022, there should not be any need for you to create alternates. Any future requests can be pointed to me and I'm happy to incorporate additional theme variants.

SmartFinn commented 1 year ago

I wasn't aware there were requests for some/all of my appindicator icons to be replaced. Could you please point me to those (assuming they are tickets/issues).

Papirus icon theme has migrated several times from one repository to another. Early, I have tried searching for the request, but without success. Looks like it was in the form of a comment on sites like gnome-look.org, or somewhere else.

As I have created what I believe are correct colours for your theme and are part of the indicators since December 2022, there should not be any need for you to create alternates. Any future requests can be pointed to me and I'm happy to incorporate additional theme variants.

Above, I already tried to explain that the issue isn't just in colors.

SmartFinn commented 1 year ago

@Bernmeister here's a compromise: I remove the indicators icons from the theme, and you do not color yours as Papirus. This is able to avoid user confusion as to why some Papirus icons bigger and out of style of others.

But I really don't understand why you don't just change your system icon theme to another instead of intervene to UI/UX of Papirus users.