search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.62k stars 419 forks source link

epapirus Snap Validation #3586

Closed ghost closed 11 months ago

ghost commented 11 months ago

Hey there @SmartFinn can you add links to the new epapirus-snap ? I have done this in line with upstream also now users of epapirus snap can get auto-connect which previously was manual due to being combined with papirus snap.

https://forum.snapcraft.io/t/global-auto-connect-request-for-icon-theme-epapirus/37598

Get it from the Snap Store

Thanks.

SmartFinn commented 11 months ago

Thanks. I've added it to README.

SmartFinn commented 11 months ago

@capecrusader-121 wait, I think the snap is broken. You've excluded Papirus from icon-theme-epapirus snap, however ePapirus and ePapirus-Dark have symlinks to Papirus. I'm not sure about dependencies in snap, but in regular packages epapirus-icon-theme requires papirus-icon-theme. If it's true, as to me, it's better do not split to different snaps.

ghost commented 11 months ago

@SmartFinn Acknowledged and fixed earlier, will push new one to stable, currently in edge. Its needed to split them since currently the user of the e* flavour have to do manual work to enjoy integration now they will also get autoconnect like regular ones also the regular one's size has a 6mb reduction.

Edit: Pushed to stable. 👍🏻

SmartFinn commented 11 months ago

@capecrusader-121 do you still want to slit it? As far as I can see, you don't need to do it. Let's imagine a situation, a user has installed a regular papirus-icon-theme package from official repo, which contains a full pack of icons, so in this case they have to download both snaps, the first with Papirus, Papirus-Dark, Papirus-Light, and the second one with Papirus, ePapirus, and ePapirus-Dark. It's insane.

ghost commented 11 months ago

@SmartFinn Hmm, Ok ? so should i take back the request for autoconnect ?

ghost commented 11 months ago

@SmartFinn See this old comment by snap reviewer

--> https://forum.snapcraft.io/t/auto-connection-request-for-icon-theme-papirus-snap/34376/7?u=samalex

SmartFinn commented 11 months ago

@capecrusader-121 I see the issue what you tried to solve, but don't. Maybe, I'll make from ePapirus a separate theme, then the separated snap will be useful.

ghost commented 11 months ago

@SmartFinn Ok then taking back the snap for now

SmartFinn commented 11 months ago

@capecrusader-121 I think you can exclude ePapirus, and ePapirus-Dark from icon-theme-papirus in this case. There are not many snap lovers on elementaryOS, and Ubuntu hasn't own distro with Pantheon Desktop.