search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.62k stars 419 forks source link

Add Timestripe icons #3592

Closed yevklim closed 11 months ago

yevklim commented 11 months ago

Timestripe is a time-management web application with the official website at https://timestripe.com.

On a desktop, it can be installed as a PWA in most Chromium-based browsers.

With this PR, I'm adding icons for Timestripe and icons-symlinks for the PWA for Brave, Chrome, and Vivaldi.

The icons of sizes 16x16, 22x22, and 24x24 look different from the higher-resolution icons because that's what the official icons of that size look like.

SmartFinn commented 11 months ago

Ha, it's the strangest way to add the light outline that I have seen. You may keep it, but it less maintainable. Also, #4f4f4f is the darker base color allowed in this icon theme, please change it.

yevklim commented 11 months ago

Initially, I made the outline a path like on most other icons in Papirus. However, using a simple rounded rectangle takes fewer characters in SVG, and it also seemed more maintainable as it's easier to change the radius, for example.

As for the color, I actually did my own research, looking for the darkest base color among Papirus icons. Most icons do have the darkest color at 31% lightness (#4f4f4f), as you defined, but I also found a few icons with a darker base color of 25% lightness (#3f3f3f). And so, I chose 25% lightness (#404040). Anyway, I respect the rules and will change the base color to 31% lightness for my icon.

Other icons with the base color at 25% lightness are angrysearch, apollo-studio, plex, tidal, pacseek, and a dozen of others too. Am I misunderstanding what the base color is here?

yevklim commented 11 months ago

Updated the base color to #4f4f4f

SmartFinn commented 11 months ago

@yevklim

However, using a simple rounded rectangle takes fewer characters in SVG, and it also seemed more maintainable as it's easier to change the radius, for example

I can't easily remove the shadows and the light outlines with sed by pattern fill:#ffffff;opacity:0.2, in this case.

Other icons with the base color at 25% lightness are angrysearch, apollo-studio, plex, tidal, pacseek, and a dozen of others too. Am I misunderstanding what the base color is here?

These may be exceptions, or these icons were added before HIG.

yevklim commented 11 months ago

Thanks for the guidelines. I will follow them more closely in this and my future contributions.

I will change the shadow and light outline as you suggested.

SmartFinn commented 11 months ago

@yevklim the shadows for inner object are missing too. Could you added it with unset fill and opacity:0.1:

image

yevklim commented 11 months ago

@SmartFinn

I made changes following the guidelines and your comments. Hope I didn't miss anything. Please review.

SmartFinn commented 11 months ago

@yevklim Thanks. This is a very good icon for the first time.