PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.46k stars 409 forks source link

Plasma 6 applets use system icons so missing many icons for applet #3595

Open CoelacanthusHex opened 7 months ago

CoelacanthusHex commented 7 months ago

Plasma 6 changed the icon name so it use the wrong icon folder-blue-network for the Bluetooth applet. https://invent.kde.org/plasma/bluedevil/-/commit/b46b05fdf33ad9e7e32103cd50ce05239c4e8c04

图片

morganist commented 7 months ago

i think a lot more icons need to be renamed because everything on widgets and panels now uses system icons. keyboard layout icon is wrong, clipboard icon is wrong when i tested it on KDE Neon Unstable (with 2022 version of Papirus from Ubuntu LTS repo).

CoelacanthusHex commented 7 months ago

i think a lot more icons need to be renamed because everything on widgets and panels now uses system icons. keyboard layout icon is wrong, clipboard icon is wrong when i tested it on KDE Neon Unstable (with 2022 version of Papirus from Ubuntu LTS repo).

Maybe some icons need to be re-drawn. e.g. I can't find the symbolic version of configure media-skip-forward media-skip-backward and more.

CoelacanthusHex commented 7 months ago

Ok, I can follow this issue to get all the icons we need to be renamed and re-drawn. I will post it here when I finish it. https://invent.kde.org/plasma/plasma-workspace/-/issues/82

CoelacanthusHex commented 7 months ago

For backward, do we need to keep the older one? If we need, should we symlink older one to newer, or newer one to older?

CoelacanthusHex commented 7 months ago

Symlink (existing icon -> symlink name):

Make new icons:

Add symlink for -symbolic:

Rename from non -symbolic in small size (https://invent.kde.org/frameworks/breeze-icons/-/commit/a205857f94906a3a0680cbec87c3d83206b363ef):

We leak some weather icon compare to breeze (https://invent.kde.org/frameworks/breeze-icons/-/commit/b6642d281e7ee3e8fd9233bfc808c97c34b199cf)

SmartFinn commented 7 months ago

I'm shocked that KDE starts using -symbolic icons for panel, instead of icons with KDE Color Scheme support. Looks like the beginning of chaos.

morganist commented 7 months ago

@SmartFinn

instead of icons with KDE Color Scheme support.

does that mean accent-coloured dots inside panel icons wouldn't work in Plasma 6 then?

SmartFinn commented 7 months ago

@morganist

does that mean accent-coloured dots inside panel icons wouldn't work in Plasma 6 then?

I've not seen yet. I see they have mixed icons that do one job, but in different way.

morganist commented 7 months ago

audio-volume-high-danger audio-volume-high-warning

https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/commit/274b2f09b042cd9db7f600d023780bca30343d47 ?

morganist commented 7 months ago

In Breeze audio-volume-high-warning: volume-warning

audio-volume-high-danger: volume-danger

SmartFinn commented 7 months ago

We can use audio-volume-overamplified-symbolic.svg icon with class="warning" and class="error" on the waves.

morganist commented 7 months ago

class="warning" and class="error"

Oh, i forgot about classes in panel icons. That's cool!

SmartFinn commented 7 months ago

Duplicate the https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/pull/3606#issuecomment-1823283775 here:

The Plasma 6 uses 22px symbolic icons instead of 16px. Papirus icon theme currently doesn't support it. Of course, we can add it symlinks into panel directory, but it not actually the symbolic icons. The symbolic icons use another classes for coloring warning, error, success. See Monochrome icons in our wiki.

VesperLlama commented 7 months ago

The icons for the power actions (shutdown, restart, logout and sleep) are also showing a blank white icon in the confirmation screen on Plasma 6 Beta 1. They show correctly in the application launcher.

Breeze - Breeze

Papirus - Papirus

morganist commented 3 months ago

I'm shocked that KDE starts using -symbolic icons for panel, instead of icons with KDE Color Scheme support. Looks like the beginning of chaos.

@SmartFinn accent colour from kde colour scheme works fine with existing icons!

image

namesarebloat commented 3 months ago

The icons for the power actions (shutdown, restart, logout and sleep) are also showing a blank white icon in the confirmation screen on Plasma 6 Beta 1. They show correctly in the application launcher.

That has been fixed by KDE. Non monochrome icons now show up correctly on the lockscreen. However, I personally would prefer monochrome/symbolic icons for both the application launcher and lockscreen, but maybe that's just me.

morganist commented 2 months ago

@CoelacanthusHex From now on, I'll be updating your https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/3595#issuecomment-1810290461 as a to-do list to catch up with Breeze icons I've found... a bunch more.