search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.46k stars 409 forks source link

Add aliases for new tray icons in Plasma 6 #3606

Closed hexchain closed 7 months ago

hexchain commented 7 months ago

Starting in Plasma 6, tray applets will start to use the system icon theme.

This change adds aliases for some of the new icons, using current ones that make sense.

SmartFinn commented 7 months ago

Thanks, I still haven't seen the Plasma, so could you add a screenshot how the icons looks on it?

morganist commented 7 months ago

related to #3595

hexchain commented 7 months ago

Here is a screenshot of the Bluetooth applet tray icon and the Network applet. Network strength and Wi-Fi security are now correctly reflected in the icon:

image

SmartFinn commented 7 months ago

@hexchain I see. This is what I was afraid of. The Plasma 6 uses 22px symbolic icons instead of 16px. Papirus icon theme currently doesn't support it. Of course, we can add it symlinks into panel directory, but it not actually the symbolic icons. The symbolic icons use another classes for coloring warning, error, success. See Monochrome icons in our wiki.

So I can't merge it for a while. I have to find the way to deal with that mess.

SmartFinn commented 7 months ago

@hexchain so, is the -symbolic suffix necessary for the icons or not?

hexchain commented 7 months ago

In the first revision, I was using icons from the symbolic directory but found them to be slightly out of place (subtly bigger?) in the tray. It also lacks the "locked wireless" icons. That's why I switched to using the "panel" icons.

As for the -symbolic suffix: I'm trying to take advantage of the icon lookup algorithm in icon-theme-spec, which basically says if the icon loader cannot find an icon with the exact name, it should chop the last -<suffix> from the name until an icon is found. In this way, the new aliases in the panel directory are still reasonable (i.e. do not claim to be symbolic when they are actually not), and Plasma Shell can still find icons that are good enough.

SmartFinn commented 7 months ago

@hexchain thanks for the info. One more question, are the icons (without -symbolic suffix) using text color from Plasma theme?

hexchain commented 7 months ago

I don't know the correct answer (as in I'm not sure whether they are designed to use the global color scheme or not), but looking at some icons in this PR in Breeze icons, they seem to support the KDE Color Scheme and they do have elements with related classes: https://invent.kde.org/frameworks/breeze-icons/-/blob/master/icons/status/22/network-wireless-40-locked.svg?ref_type=heads&plain=1

SmartFinn commented 7 months ago

@hexchain is the screenshot above with symbolic icons, or not? If these are symbolic icons, please add another screenshot with the icons in PR.

hexchain commented 7 months ago

No, they are not symbolic icons.

SmartFinn commented 7 months ago

@hexchain

No, they are not symbolic icons.

Great. I'll merge this PR later.

hexchain commented 7 months ago

But here is a new screenshot anyway, with icons in a smaller panel: image

morganist commented 7 months ago

@hexchain May I ask what distro you use to test plasma 6? I'm just curious. I've tried neon unstable in a VM but I don't have a device to install it to. Do you use something like KDE Neon Testing daily already?

hexchain commented 7 months ago

@hexchain May I ask what distro you use to test plasma 6? I'm just curious. I've tried neon unstable in a VM but I don't have a device to install it to. Do you use something like KDE Neon Testing daily already?

Hi, I use Arch Linux (btw) and have set up a Plasma development environment to build Plasma 6, using this guide.

morganist commented 7 months ago

@hexchain Cool! Thanks for the info.

hexchain commented 7 months ago

@SmartFinn Gentle prod :-)