search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.46k stars 409 forks source link

Add KDE Colorsheme Folders #3614

Closed Link1J closed 7 months ago

Link1J commented 7 months ago

This is my attempt at doing #3561, but unlike it, theses are generated via script, so they should be more maintainable. I know that new folder colours aren't welcome, but I hope that because of how specialized these are, they will be welcomed in.

I would have like to make these the default instead of the blue ones, so that it mimics breeze when on KDE, but becuase of a bug (https://bugs.kde.org/show_bug.cgi?id=446468), I didn't do that. That bug also affects this, so there isn't much I could do about it.

SmartFinn commented 7 months ago

Thanks. That is an interesting way, I even didn't think to do it in that way. I still don't sure to add these folders, or not, but I'll merge this PR right now, if you remove commits with the generated folders.

Dejweed commented 7 months ago

If this is merged, the KDE colorscheme section in the readme.md could be updated, I don't think the current description is up to date.

SmartFinn commented 7 months ago

@Dejweed what would you like to update in the KDE colorscheme section? It looks OK for me. More technical details are placed in our wiki page.

Dejweed commented 7 months ago

The wiki looks great. But changing the Papirus and Papirus-Dark as mentioned here makes no difference to me. The Plasma panel (currently 5.27.9) uses icons from it's plasma theme, so system icons don't get applied here. Plasma 6 however will use system icons, more of this related to #3595. I hope they will find a good way to implement this, currently it looks like a mess with -symbolic icons like you pointed out.

For these folders I would mention it somewhere like For KDE colorscheme use this folders color...

SmartFinn commented 7 months ago

@Dejweed

But changing the Papirus and Papirus-Dark as mentioned here makes no difference to me. The Plasma panel (currently 5.27.9) uses icons from it's plasma theme, so system icons don't get applied here.

I'm not a KDE user, but I suppose you need to change the icon theme for apps that do not support nor -symbolic nor KDE Color Scheme (e.q. pcmanfm-gtk3, qBittorrent, etc), like GNOME users do.

Dejweed commented 7 months ago

Yeah you are right. I suppose it's best we wait for Plasma 6 and change it then.

@Dejweed what would you like to update in the KDE colorscheme section? It looks OK for me. More technical details are placed in our wiki page.

For now I would just like to let people know that kde color scheme folders exist (in this case Chameleon).

SmartFinn commented 7 months ago

@Dejweed I'm not sure the folders will be added as an optional in papirus-folders. I would see these folders as default, or a separated icon theme, like https://github.com/varlesh/papirus-colors.

SmartFinn commented 7 months ago

@Link1J Thanks!