search

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.46k stars 409 forks source link

convert.sh does not do its job #3622

Closed MightySpaceman closed 6 months ago

MightySpaceman commented 6 months ago

I'm contributing for the first time, have the icons correctly named and placed, running the convert script, but nothing. No new icons in work/Papirus-Dark/apps, nor any for ePapirus or Papirus-Light. In each there is only a set of empty folders. Am I doing something wrong or is this a bug?

Running the command: image

Tree of tools/work afterwards:

├── clean.sh
├── convert.sh
├── ePapirus
│   ├── actions
│   ├── devices
│   ├── panel
│   └── places
├── ePapirus-Dark
│   ├── actions
│   ├── apps
│   ├── devices
│   └── places
├── examples-papirus.svg
├── font.svg
├── get-from-theme.sh
├── keyboard-font.svg
├── Makefile
├── new-icon.sh
├── new-symlink.sh
├── Papirus
│   ├── actions
│   │   ├── _TEMPLATE@16x16.SVG
│   │   ├── _TEMPLATE@22x22.SVG
│   │   └── _TEMPLATE@24x24.SVG
│   ├── apps
│   │   ├── splitgate@16x16.svg
│   │   ├── splitgate@22x22.svg
│   │   ├── splitgate@24x24.svg
│   │   ├── splitgate@32x32.svg
│   │   ├── splitgate@48x48.svg
│   │   ├── splitgate@64x64.svg
│   │   ├── _TEMPLATE@16x16.SVG
│   │   ├── _TEMPLATE@22x22.SVG
│   │   ├── _TEMPLATE@24x24.SVG
│   │   ├── _TEMPLATE@32x32.SVG
│   │   ├── _TEMPLATE@48x48.SVG
│   │   └── _TEMPLATE@64x64.SVG
│   ├── devices
│   │   ├── _TEMPLATE@16x16.SVG
│   │   ├── _TEMPLATE@22x22.SVG
│   │   ├── _TEMPLATE@24x24.SVG
│   │   ├── _TEMPLATE@32x32.SVG
│   │   ├── _TEMPLATE@48x48.SVG
│   │   └── _TEMPLATE@64x64.SVG
│   ├── emblems
│   │   ├── _TEMPLATE@16x16.SVG
│   │   ├── _TEMPLATE@22x22.SVG
│   │   ├── _TEMPLATE@24x24.SVG
│   │   ├── _TEMPLATE@32x32.SVG
│   │   └── _TEMPLATE@48x48.SVG
│   ├── mimetypes
│   │   ├── _TEMPLATE@16x16.SVG
│   │   ├── _TEMPLATE@22x22.SVG
│   │   ├── _TEMPLATE@24x24.SVG
│   │   ├── _TEMPLATE@32x32.SVG
│   │   ├── _TEMPLATE@48x48.SVG
│   │   └── _TEMPLATE@64x64.SVG
│   ├── panel
│   │   ├── _TEMPLATE@16x16.SVG
│   │   ├── _TEMPLATE@22x22.SVG
│   │   └── _TEMPLATE@24x24.SVG
│   ├── places
│   │   ├── _TEMPLATE@16x16.SVG
│   │   ├── _TEMPLATE@22x22.SVG
│   │   ├── _TEMPLATE@24x24.SVG
│   │   ├── _TEMPLATE@32x32.SVG
│   │   ├── _TEMPLATE@48x48.SVG
│   │   └── _TEMPLATE@64x64.SVG
│   └── status
│       ├── _TEMPLATE@22x22.SVG
│       ├── _TEMPLATE@24x24.SVG
│       ├── _TEMPLATE@32x32.SVG
│       └── _TEMPLATE@48x48.SVG
├── Papirus-Dark
│   ├── actions
│   ├── apps
│   ├── devices
│   ├── emblems
│   ├── mimetypes
│   ├── places
│   └── status
├── Papirus-Light
│   └── panel
├── prepare.sh
├── put-into-theme.sh
├── README.md
└── splitgate.svg

(the icon is for splitgate, for context of which files I put there)

morganist commented 6 months ago

convert.sh is for symbolis icons so that there are dark and light versions. It doesn't do anything for app icons. It a user applies Papirus-Dark, all icons for apps come from Papirus folder, no converting needed.

morganist commented 6 months ago

By the way, thanks for contributing! Have you read the contributing guide and the project wiki? Lots of useful tips there.

MightySpaceman commented 6 months ago

By the way, thanks for contributing! Have you read the contributing guide and the project wiki? Lots of useful tips there.

Yep, had a look around, probably just didn't read it well enough lol, apologies. I'll close the issue here