More symbolic links for VSCode variants

PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux

https://git.io/papirus-icon-theme

GNU General Public License v3.0

6.46k stars 408 forks source link

More symbolic links for VSCode variants #3651

Closed QuentiumYT closed 4 months ago

QuentiumYT commented 4 months ago

Hello, I came across this small issue I have the correct icon for code variants except vscode-insiders. So I checked and there were missing icons for that. I also added all the naming for code exploration as well.

Made visual-studio-code-exploration.svg the default SVG instead of vscode-exploration.svg to keep consistency between versions.

I hope you like it :) and thanks for the scripts, works fine!

SmartFinn commented 4 months ago

Thanks for the PR. As I see, you have added 4 symlinks:

[ ] code-exploration
[ ] com.visualstudio.code.insiders
[x] vscode-insiders https://packages.microsoft.com/repos/vscode/pool/main/c/code-insiders/
[ ] visual-studio-code-exploration

And renamed vscode-exploration to visual-studio-code-exploration.

However, I have found only 1 icon name used in the official DEB/RPM packages. And vscode-exploration is the default icon name for the official code-exploration package, not visual-studio-code-exploration.

Please, could you add links to the packages?

QuentiumYT commented 4 months ago

I linked every icon 4 times, with all 4 symlinks regarding the normal code and code-insiders. So I guess all other code icons are not correct either? What if the icon is a symlink and not the original svg tho?

SmartFinn commented 4 months ago

Let's find the right icon names first, or are you sure that other icons don't get used? In this case, I recommend closing this PR and create a new one, where visual-studio-code-insiders.svg will be renamed to vscode-insiders, and code-insiders.svg will be removed.

QuentiumYT commented 4 months ago

I checked my installed code, all start with vscode, as well as archives on the remote packages. But I think it would be better if more icons are available right? Perhaps it changed from one version to another? As you want, this PR was just to allow uniforming all icon names for different vscode variants

SmartFinn commented 4 months ago

Adding symlinks for icon names that never be used is nonsense. As keeping icons for the old version of software. Each symlink costs 4 KB of the disk space. Who wants to use the older software should use the older Papirus icon theme.

I checked my installed code, all start with vscode, as well as archives on the remote packages

I'he checked too, the versions from 1.85 to 1.87 are using vscode-* icon names, and vscode-insiders is missing in this icon theme.

QuentiumYT commented 4 months ago

Alright, I will create a new PR with only the vscode-* icon names then, with no symlinks :)

SmartFinn commented 4 months ago

Please, do it for VSCode Insiders and VSCode Exploration only. I'm not sure about VSCode, it has much more packages and the icon names.