PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.45k stars 407 forks source link

Missing symbolic icons on newer GTK4 apps from Flathub #3699

Open owzim opened 2 months ago

owzim commented 2 months ago

Some Icons are missing, when using Papirus.

Screenshot from 2024-04-21 21-11-17

Icons are not missing when using Adwaita.

Screenshot from 2024-04-21 21-26-57

Obviously the icons are new icons of the Adwaita icons theme. My question is, what is happening here. Is there no fallback mechanism? Do alternative icon themes always have to have an icon with the same name?

Thanks

morganist commented 2 months ago

My question is, what is happening here. Is there no fallback mechanism?

Maybe libadwaita devs have changed some icon names? I've noticed missing icons where they were previously there. We'll look into that.

owzim commented 2 months ago

@morganist is there something more I can provide?

owzim commented 2 months ago

image

The Yaru Theme (Ubuntu 22.04) has those icons too.

Asherathe commented 1 month ago

My understanding is that Gnome deliberately stopped supporting icon theming.

owzim commented 1 month ago

@Asherathe can you provide any evidence of that being the case?

The fact that Ubuntu's Yaru icon theme is working contradicts that assumption, does it not?

Raindrac commented 3 weeks ago

Determined to fix this issue for myself, I dug into potential causes, and I've found both a workaround and the surface-level cause of the issue. That issue is that these applications are only loading symbolic icons from icon themes located in /usr/share/icons. If Papirus, or any other icon theme, is installed to a different directory (such as ~/.local/share/icons) then the symbolic icons will break in the affected applications.

I confirmed this by creating a duplicate of the working Adwaita theme and renaming it to Adwaita-Copy. If Adwaita-Copy is installed into ~/.local/share/icons, symbolic icons won't load in the affected applications. This is in spite of how the theme is identical to a working theme, Adwaita.

By installing Papirus directly to /usr/share/icons, the issue went away. If you're running an atomic distribution like me, that directory is read-only; you can work around it by creating an rpm package and layering it with rpm-ostree. If you're using another distro, just move the folder over there normally.

The bug that's causing this is upstream of Papirus, so for now I suggest using this workaround. Someone more experienced with debugging might want to see if they can identify where the issue is located upstream and submit a bug report to the relevant issue tracker.