PapirusDevelopmentTeam / papirus-icon-theme

Pixel perfect icon theme for Linux
https://git.io/papirus-icon-theme
GNU General Public License v3.0
6.65k stars 423 forks source link

Megasync 3.5 in xfce #943

Closed hxss closed 6 years ago

hxss commented 6 years ago

@varlesh, you said that megasync now support icon themes. But in xfce I still see original colored icon.

Can you help me fix this bug?

image

4.13.12-1-ARCH megasync 3.5-1(from official site) Papirus-icons(updated right now and I see new mega icons in /ust/share/...)

varlesh commented 6 years ago

image

varlesh commented 6 years ago

tested on KDE Neon

varlesh commented 6 years ago

Also see this: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/549

hxss commented 6 years ago

@varlesh

pactree -d 1 megasync
megasync
├─glibc
├─gcc-libs
├─qt5-base
├─sqlite
├─openssl
├─zlib
└─qt5-svg

Also see this: #549

Do you offer me to use hardcode-tray or unity?

varlesh commented 6 years ago

This icons not hardcoded anymore. Please see #549

varlesh commented 6 years ago

It's upstream bug xfce4-session: https://bugzilla.xfce.org/show_bug.cgi?id=12012 It's happened because xfce4-session compiled with flag --disable-legacy-sm - that breaks qt4 integration on xfce.

hxss commented 6 years ago

Isn't megasync use qt5?

pactree -d 1 megasync
megasync
├─glibc
├─gcc-libs
├─qt5-base
├─sqlite
├─openssl
├─zlib
└─qt5-svg
varlesh commented 6 years ago

Yes, i know but maybe it's happened for qt5-apps too. Try it. i'm not use xfce. On Unity and KDE megasync use icons from Papirus. It's XFCE bug

varlesh commented 6 years ago

Also check Qt5 settings on XFCE. For better looking recommend use qt5ct tool

varlesh commented 6 years ago

It's available on community arch repo https://www.archlinux.org/packages/community/x86_64/qt5ct/

varlesh commented 6 years ago

https://wiki.archlinux.org/index.php/Uniform_look_for_Qt_and_GTK_applications

hxss commented 6 years ago

I'm already use qt5ct.

varlesh commented 6 years ago

i don't know how help you. You see my screen, on KDE it's worked fine

varlesh commented 6 years ago

@hxss other qt5-apps use system icon theme - qBittorrent, clementine-qt5 and etc?

hxss commented 6 years ago

@varlesh qbittorrent and keepassxc use your icons without hardcode. image

varlesh commented 6 years ago

hm, it's very strange

hxss commented 6 years ago

this is from README in arch xfce-session:

Legacy session management:

As of version 4.1.7, the session manager includes native support for applications that don't support the X11R6 session management protocol, but support legacy (X11R5) session management. If you don't need legacy session management support, you can disable it at compile time, giving --disable-legacy-sm to ./configure.

I'm now trying understand how to compile it with --enable-legacy-sm

hxss commented 6 years ago

ok, it seems like I was able to compile xfce4-session with --enable-legacy-sm and install it.

Then I logout/login and nothing changed. Still red mega icon in tray.

varlesh commented 6 years ago

i'm extract megasync 3.5.1 deb package and see this:

Package: megasync
Version: 3.5-1.1
Architecture: amd64
Maintainer: MEGA Linux Team <linux@mega.co.nz>
Installed-Size: 7963
Depends: libc-ares2 (>= 1.7.4), libc6 (>= 2.16), libcrypto++9v5, libgcc1 (>= 1:3.0), libqt4-dbus (>= 4:4.5.3), libqt4-network (>= 4:4.7.0~beta1), libqt4-svg (>= 4:4.5.3), libqtcore4 (>= 4:4.8.0), libqtgui4 (>= 4:4.8.0), libsqlite3-0 (>= 3.5.9), libssl1.0.0 (>= 1.0.2~beta3), libstdc++6 (>= 5.2), apt-transport-https
Section: Tools
Priority: normal
Description: Easy automated syncing between your computers and your MEGA cloud drive
 Secure:
 Your data is encrypted end to end. Nobody can intercept it while in storage or in transit.
 Flexible:
 Sync any folder from your PC to any folder in the cloud. Sync any number of folders in parallel.
 Fast:
 Take advantage of MEGA's high-powered infrastructure and multi-connection transfers.
 Generous:
 Store up to 50 GB for free!

Used Qt4 libs...

varlesh commented 6 years ago

maybe qt5-version not support this?

hxss commented 6 years ago

in arch mega.pkg.tar.xz only binary file and icons. But pkg has dependencies from qt5-base and qt5-svg. VLC(it use qt4 for gui?) also show colored icon in tray.

hxss commented 6 years ago
megasync --debug
qt5ct: using qt5ct plugin
21:33:07 (debug):  stablishing ratio to = 1
qt5ct: using qt5ct plugin
21:33:08 (debug): QT Debug: D-Bus system tray: no
21:33:08 (debug): QT Context: qt5ct    2
21:33:08 (warn):  QT Warning: QSystemTrayIcon::setVisible: No Icon set
21:33:08 (warn):  QT Context: default    2
21:33:08 (debug): cURL version: 7.49.1 (net.cpp:75)
...
varlesh commented 6 years ago

vlc used monochrome icon on Unity and KDE only. it's worked with name -panelsuffix. Also for KDE icon used from plasma theme and it's worked for qt-apps only on KDE.

try run with: XDG_CURRENT_DESKTOP=kde megasync or XDG_CURRENT_DESKTOP=Unity megasync

hxss commented 6 years ago

every time red icon and:

XDG_CURRENT_DESKTOP=kde megasync                                                                                                           [~] 
qt5ct: using qt5ct plugin
qt5ct: using qt5ct plugin
libpng error: Not a PNG file
varlesh commented 6 years ago

https://www.archlinux.org/packages/?sort=&q=libpng&maintainer=&flagged=

hxss commented 6 years ago

already installed

hxss commented 6 years ago

I exec sudo ln -sf /usr/share/icons/Papirus/22x22/panel/mega* /usr/share/icons/hicolor/scalable/status.

Logged out/in but still red icon. I was sure, that this action 100% gives me normal icons! 🙁

varlesh commented 6 years ago

Sorry i can't test qt5-version. For Ubuntu 16.04 available only qt4-version

varlesh commented 6 years ago

@hxss error libpng error: Not a PNG file maybe try convert SVG to PNG?

hxss commented 6 years ago

I can try. But original mega icon in svg too

varlesh commented 6 years ago

I mean maybe it's bug qt5ct on XFCE.... but other Qt5-apps show svg icons on tray. It's very strange bug

varlesh commented 6 years ago

I'm reopen issue. maybe anybody help you

varlesh commented 6 years ago

@Lupusaurus @eldelacajita @infuerano @akyag Hi guys, Megasync used tray icons from Papirus? And please tell what you version use Qt4/Qt5 and DE Thx!

hxss commented 6 years ago

... and dependencies of megasync in your OS, please

varlesh commented 6 years ago

See https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/943#issuecomment-348721135

hxss commented 6 years ago

but in my system this is qt5

varlesh commented 6 years ago

@hxss Package for ubuntu 17.10 (qt5):

Package: megasync
Version: 3.5-1.1
Architecture: amd64
Maintainer: MEGA Linux Team <linux@mega.co.nz>
Installed-Size: 8072
Depends: libc-ares2 (>= 1.7.4), libc6 (>= 2.25), libcrypto++6, libgcc1 (>= 1:3.0), libqt5core5a (>= 5.9.0~beta), libqt5dbus5 (>= 5.0.2), libqt5gui5 (>= 5.8.0), libqt5network5 (>= 5.1.0), libqt5svg5 (>= 5.6.0~beta), libqt5widgets5 (>= 5.2.0~alpha1), libsqlite3-0 (>= 3.5.9), libssl1.0.0 (>= 1.0.2~beta3), libstdc++6 (>= 5.2), apt-transport-https
Section: Tools
Priority: normal
Description: Easy automated syncing between your computers and your MEGA cloud drive
 Secure:
 Your data is encrypted end to end. Nobody can intercept it while in storage or in transit.
 Flexible:
 Sync any folder from your PC to any folder in the cloud. Sync any number of folders in parallel.
 Fast:
 Take advantage of MEGA's high-powered infrastructure and multi-connection transfers.
 Generous:
 Store up to 50 GB for free!
hxss commented 6 years ago

added issue to megasync

hxss commented 6 years ago

png icons didn't work too

bilelmoussaoui commented 6 years ago

@hxss just use Hardcode-Tray ;)

hxss commented 6 years ago

@bil-elmoussaoui if it worked.. I was try Hardcode-Tray as first solution.

And see #943 (comment)

bilelmoussaoui commented 6 years ago

The icons are not hardcoded anymore, but megasync picks up the icons from hicolor; don't know why. + you have to update the icon cache of hicolor.

That's why i suggested to you to use hardcode-tray ;)

hxss commented 6 years ago
sudo hardcode-tray --apply
sudo gtk-update-icon-cache -f -t /usr/share/icons/hicolor
xfce4-panel -r #restart
*restart megasync*

still red

n1c0saurio commented 6 years ago

Hi, in Pantheon (eOS Loki) works well: captura

And in my OS Megasync uses Qt4 dependences.

varlesh commented 6 years ago

solved https://github.com/meganz/MEGAsync/issues/149#issuecomment-354794215