transactional-adapter-pg-promise: where are the default tx options merged with tx-specific options?

Papooch / nestjs-cls

A continuation-local storage (async context) module compatible with NestJS's dependency injection.

https://papooch.github.io/nestjs-cls/

MIT License

453 stars 29 forks source link

Closed sam-artuso closed 6 months ago

sam-artuso commented 6 months ago

Hi, after version 1.3.0 of transactional-adapter-pg-promise the default options seem to no longer be merged in.

I cannot find where this happens in the source code. Is this a bug?

sam-artuso commented 6 months ago

Perhaps here? Default options are not working for me though. Will try and create a minimal reproducible example as soon as I get a chance.

Papooch commented 6 months ago

Hi, I'm sorry, I should've probably let you know.

I moved the feature to the TransactionHost itself, so all adapters can take advantage of it without explicitly implementing the feature.

Please make sure to also update @nestjs-cls/transactional to latest version.

Papooch commented 6 months ago

@sam-artuso Does it work for you on the latest version?

sam-artuso commented 6 months ago

Yes, it does work :)