Closed ruslanguns closed 2 years ago
TypeScript version?
This was implemented in https://github.com/microsoft/TypeScript/pull/44512 which I think was released in 4.4.
Morning FYI @joebowbeer I have created two different tests:
Using version rolling back cls to v1.6.2 and works smoothly: https://github.com/ruslanguns/cqrs-with-cls/tree/Using-CLS-1.6.2
Rolling back typescript to v4.4 and works smootly: https://github.com/ruslanguns/cqrs-with-cls/tree/RollbackTypeScript-4.4
EDITION: I was meaning Rolling up, instead of back!!!
@ruslanguns regarding 2)
Didn't you mean upgrading to typescript 4.4
? I remember you saying it didn't work on 4.3
. That would mean this is actually a non-issue and it's only needed to add the minimum version requirement to the readme.
However, if your PR fixes it for lower versions as well, I'll be more than happy to merge it
Thanks for clarifying and yes, sorry for my mistake I was meaning rolling up... definitely the problem happens in versions before v4.4 like v4.3.5 which I was... the change with Record allows me to work with v4.3.5 smoothly
Works as intended with typescript
>= 4.4
. See the linked PR for more info.
I am getting the following typing error when trying to use the package.
Reproduction repository: https://github.com/ruslanguns/cqrs-with-cls
System information