search

ParBLiSS / FastANI

Fast Whole-Genome Similarity (ANI) Estimation
Apache License 2.0
374 stars 67 forks source link

include <algorithm> in fastani_tests.cpp #120

Closed douglasgscofield closed 1 year ago

douglasgscofield commented 1 year ago

Added #include <algorithm> to tests/fastani_tests.cpp. Without this, with at least gcc 9.3.0 and 11.3.0 we get

[ 98%] Building CXX object CMakeFiles/fastANITest.dir/tests/fastani_tests.cpp.o
/sw/bioinfo/FastANI/1.34/src/FastANI/tests/fastani_tests.cpp: In function 'std::vector<std::__cxx11::basic_string<char> > get_file_contents(const string&)':
/sw/bioinfo/FastANI/1.34/src/FastANI/tests/fastani_tests.cpp:28:10: error: 'sort' is not a member of 'std'
   28 |     std::sort(file_contents.begin(), file_contents.end());
      |          ^~~~
make[2]: *** [CMakeFiles/fastANITest.dir/tests/fastani_tests.cpp.o] Error 1
codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (88c0cf9) 95.86% compared to head (99694c4) 95.86%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #120 +/- ## ======================================= Coverage 95.86% 95.86% ======================================= Files 12 12 Lines 846 846 ======================================= Hits 811 811 Misses 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.