ParBLiSS / FastANI

Fast Whole-Genome Similarity (ANI) Estimation
Apache License 2.0
368 stars 66 forks source link

Compiling fastANI on macOS but using gcc (solved) #17

Open tseemann opened 6 years ago

tseemann commented 6 years ago
==> make install
g++-8 -O3 -DNDEBUG -std=c++11 -Isrc -I /usr/local/opt/boost/include -fopenmp -mmacosx-version-min=10.7 -stdlib=libc++ -DUSE_BOOST src/cgi/core_genome_identity.cpp -o fastANI /usr/local/opt/boost/lib/libboost_math_c99.a -lstdc++ -lz -lm  
g++-8: error: unrecognized command line option '-stdlib=libc++'
make: *** [fastANI] Error 1

It still seems to be passing clang++ specific parameters to g++ ie. mmacosx-version-min=10.7 -stdlib=libc++

Ok I now see in Makefile.in where it occurs:

ifeq ($(UNAME_S),Darwin)
    CXXFLAGS += -mmacosx-version-min=10.7 -stdlib=libc++
else
    CXXFLAGS += -include src/common/memcpyLink.h -Wl,--wrap=memcpy
    CFLAGS += -include src/common/memcpyLink.h
endif

Can you change the if Darwin to if Darwin and not GCC ?

tseemann commented 6 years ago

Ok, i figured out what needs to be doen https://github.com/brewsci/homebrew-bio/pull/363

  1. The if is for Darwin + Clang
  2. The `else is for Linux + GCC

You need a 3rd case:

  1. For Darwin + GCC, you need no options
tseemann commented 4 years ago

Any movement on this?