search

ParRes / Kernels

This is a set of simple programs that can be used to explore the features of a parallel platform.
https://groups.google.com/forum/#!forum/parallel-research-kernels
Other
409 stars 107 forks source link

Enable P2P for oneTBB #547

Closed reble closed 3 years ago

reble commented 3 years ago

Opting out or removing more deprecated interfaces (atomic, parallel_do), maintaining backwards compatibility. Makes the code a little bit ugly. :-)

Explicit include of tbb/version.h has to be removed to maintain backwards compatibility. Issue created by previous PR.

jeffhammond commented 3 years ago

I don't think this code ever worked. Did you try it? Might be better to delete than update if it's broken anyways.

reble commented 3 years ago

Why do you think it never worked? Yes I tried it. Manually tested the example with TBB 2017, 2019 and 2021, gcc and clang. Without the changes in this PR TBB 2021 can't be used because of its deprecated functionality. But for TBB 2017 + 2019 the example compiles and solution validates. So I don't think the example is fundamentally broken and should be removed.

jeffhammond commented 3 years ago

Ah, if it works for you, then perhaps someone else fixed it and I just forgot. I remember failing miserable to write a "parallel do feeder" version before TBB experts got involved, but I thought you only created the (good) flow graph version.

Anyways, I will merge. If it works for you, that is more than sufficient here.