ParaToolsInc / salt

2 stars 0 forks source link

Replace hard-coded instrumentation with configurable instrumentation #1

Closed nchaimov closed 1 year ago

nchaimov commented 2 years ago

The existing libTooling-based instrumentor hard-codes the lines of code to be inserted to initialize TAU, start and top timers, etc. This should be changed so that the instrumentation can be specified by a configuration file.

We will need options for things like:

We should also review other instrumentation APIs to determine what other instrumentation points might be necessary.

khuck commented 2 years ago

Suggested libraries to examine:

Most of these libraries have marker events, timer start/stop, region push/pop, etc. sometimes they are thread-local, sometimes they are not.

zbeekman commented 1 year ago

@PlatinumCD @nchaimov Is there a reason this issue was reopened? Is it because of the dockerhub comments on the PR? Something else?

PlatinumCD commented 1 year ago

@zbeekman I am not sure why I closed and reopened back in July. This might have been a mistake.

nchaimov commented 1 year ago

I don't think this was meant to have been reopened. I'll close it again.