search

ParaToolsInc / taucmdr

Performance engineering for the rest of us.
http://www.taucommander.com
Other
29 stars 11 forks source link

Issue373 #382

Closed PlatinumCD closed 4 years ago

PlatinumCD commented 4 years ago

Libelf and Libdwarf installation packages. All tests should pass.

codecov[bot] commented 4 years ago

Codecov Report

Merging #382 into unstable will decrease coverage by 0.27%. The diff coverage is 88.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #382      +/-   ##
============================================
- Coverage     68.18%   67.91%   -0.28%     
============================================
  Files            96       98       +2     
  Lines          8552     8592      +40     
  Branches       1465     1469       +4     
============================================
+ Hits           5831     5835       +4     
- Misses         2185     2223      +38     
+ Partials        536      534       -2
Flag Coverage Δ
#CI 67.91% <88.63%> (-0.28%) :arrow_down:
#unittests 67.91% <88.63%> (-0.28%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/taucmdr/model/target.py 60.97% <ø> (ø)
packages/taucmdr/cf/software/tau_installation.py 55.33% <70.58%> (+0.07%) :arrow_up:
...kages/taucmdr/cf/software/libdwarf_installation.py 100.00% <100.00%> (ø)
...ackages/taucmdr/cf/software/libelf_installation.py 100.00% <100.00%> (ø)
packages/taucmdr/util.py 63.10% <0.00%> (-6.62%) :arrow_down:
packages/taucmdr/cf/software/installation.py 61.99% <0.00%> (-1.35%) :arrow_down:
github-actions[bot] commented 4 years ago

Pylint Output

Report

8698 statements analysed.

Statistics by type

type number old number difference %documented %badname
module 99 97 +2.00 100.00 0.00
class 128 126 +2.00 99.22 0.78
method 693 689 +4.00 98.70 0.87
function 117 117 = 94.87 0.85

Raw metrics

type number % previous difference
code 10463 50.92 10417 +46.00
docstring 5355 26.06 5318 +37.00
comment 3034 14.77 2980 +54.00
empty 1694 8.24 1669 +25.00

Duplication

now previous difference
nb duplicated lines 0 0 =
percent duplicated lines 0.000 0.000 =

Messages by category

type number previous difference
convention 26 26 =
refactor 16 16 =
warning 25 25 =
error 0 0 =

% errors / warnings by module

module error warning refactor convention
taucmdr.model.experiment 0.00 36.00 0.00 3.85
taucmdr.cf.storage.sqlite3_file 0.00 16.00 6.25 11.54
taucmdr.util 0.00 4.00 18.75 3.85
taucmdr.model.trial 0.00 4.00 12.50 0.00
taucmdr.model.project 0.00 4.00 12.50 0.00
taucmdr.model.target 0.00 4.00 6.25 0.00
taucmdr.cf.storage.local_file 0.00 4.00 6.25 0.00
taucmdr.cf.software.papi_installation 0.00 4.00 0.00 7.69
taucmdr.cf.storage.levels 0.00 4.00 0.00 3.85
taucmdr.cli.commands.trial.renumber 0.00 4.00 0.00 0.00
taucmdr.cli.commands.target.edit 0.00 4.00 0.00 0.00
taucmdr.cli.commands.target.create 0.00 4.00 0.00 0.00
taucmdr.cli.commands.target.copy 0.00 4.00 0.00 0.00
taucmdr.init 0.00 4.00 0.00 0.00
taucmdr.cf.software.tau_installation 0.00 0.00 18.75 26.92
taucmdr.cf.compiler.init 0.00 0.00 6.25 3.85
taucmdr.cli.commands.select 0.00 0.00 6.25 0.00
taucmdr.cli.init 0.00 0.00 6.25 0.00
taucmdr.mvc.model 0.00 0.00 0.00 7.69
taucmdr.mvc.controller 0.00 0.00 0.00 7.69
taucmdr.progress 0.00 0.00 0.00 3.85
taucmdr.model.application 0.00 0.00 0.00 3.85
taucmdr.error 0.00 0.00 0.00 3.85
taucmdr.cli.commands.experiment.edit 0.00 0.00 0.00 3.85
taucmdr.cli.arguments 0.00 0.00 0.00 3.85
taucmdr.cf.software.sqlite3_installation 0.00 0.00 0.00 3.85

Messages

message id occurrences
missing-docstring 16
arguments-differ 12
inconsistent-return-statements 10
invalid-name 4
useless-super-delegation 3
line-too-long 3
fixme 3
bad-continuation 3
too-many-nested-blocks 2
too-many-locals 2
logging-format-interpolation 2
unused-import 1
unused-argument 1
too-many-public-methods 1
redefined-builtin 1
raising-format-tuple 1
no-else-return 1
logging-not-lazy 1

Your code has been rated at 9.81/10 (previous run: 9.81/10, +0.00)

Per-file output (click to expand) 
************* Module taucmdr
W: 42, 4: Redefining built-in 'basestring' (redefined-builtin)
************* Module taucmdr.error
C: 76, 4: Missing method docstring (missing-docstring)
************* Module taucmdr.progress
C:178, 4: Missing method docstring (missing-docstring)
************* Module taucmdr.cf.software.sqlite3_installation
C: 51, 0: Line too long (121/120) (line-too-long)
************* Module taucmdr.cf.software.papi_installation
C: 49, 0: Wrong continued indentation (add 7 spaces).
         'http://fs.paratools.com/tau-mirror/papi-5.5.1.tar.gz']}
         ^      | (bad-continuation)
W: 69, 4: Parameters differ from overridden '_prepare_src' method (arguments-differ)
C: 77, 8: Variable name "cc" doesn't conform to u'[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
************* Module taucmdr.util
R:143, 0: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
R:423, 0: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
W:465,18: Unused argument 'label' (unused-argument)
R:714, 4: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
C:734, 4: Missing function docstring (missing-docstring)
************* Module taucmdr.cf.storage.levels
C: 64, 0: Missing function docstring (missing-docstring)
W: 42, 0: Unused import os (unused-import)
************* Module taucmdr.cf.storage.local_file
W: 80, 4: Parameters differ from overridden 'write' method (arguments-differ)
R:227, 4: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module taucmdr.cf.compiler
R:300, 8: Too many nested blocks (6/5) (too-many-nested-blocks)
C:662, 4: Missing method docstring (missing-docstring)
************* Module taucmdr.mvc.controller
C: 54, 0: Missing function docstring (missing-docstring)
C: 55, 4: Missing function docstring (missing-docstring)
************* Module taucmdr.mvc.model
C: 75, 4: Missing method docstring (missing-docstring)
C:349,16: Missing function docstring (missing-docstring)
************* Module taucmdr.cf.storage.sqlite3_file
W:539, 0: TODO This could be made more efficient if we make this function less general. (fixme)
W:682, 0: TODO Change this to use a single operation (fixme)
C:227, 0: Wrong continued indentation (add 5 spaces).
                  log=False)
                  ^    | (bad-continuation)
W:112,29: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
W:136,25: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
C:276, 4: Missing method docstring (missing-docstring)
C:295, 4: Missing method docstring (missing-docstring)
R:419,12: Unnecessary "else" after "return" (no-else-return)
************* Module taucmdr.cf.software.tau_installation
C:896, 0: Wrong continued indentation (remove 1 space).
                  ] if flag]
                 |^ (bad-continuation)
C:953, 0: Line too long (123/120) (line-too-long)
C:845,45: Variable name "f" doesn't conform to u'[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
C:950, 4: Missing method docstring (missing-docstring)
R:975, 4: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
R:1753, 4: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
C:1902, 4: Missing method docstring (missing-docstring)
C:1927, 8: Variable name "p" doesn't conform to u'[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
C:1928, 8: Variable name "m" doesn't conform to u'[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
R:169, 0: Too many public methods (27/25) (too-many-public-methods)
************* Module taucmdr.cli
R:230, 0: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module taucmdr.cli.arguments
C:476, 0: Line too long (123/120) (line-too-long)
************* Module taucmdr.cli.commands.select
R:118, 4: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module taucmdr.cli.commands.trial.renumber
W: 84, 8: Specify string format arguments as logging function parameters (logging-not-lazy)
************* Module taucmdr.cli.commands.experiment.edit
C: 39, 0: Missing class docstring (missing-docstring)
************* Module taucmdr.cli.commands.target.edit
W: 61,12: Parameters differ from overridden '__call__' method (arguments-differ)
************* Module taucmdr.cli.commands.target.copy
W: 59,12: Parameters differ from overridden '__call__' method (arguments-differ)
************* Module taucmdr.cli.commands.target.create
W: 68,12: Parameters differ from overridden '__call__' method (arguments-differ)
************* Module taucmdr.model.application
C: 50, 0: Missing function docstring (missing-docstring)
************* Module taucmdr.model.project
W: 98, 4: Parameters differ from overridden 'delete' method (arguments-differ)
R:142, 4: Too many local variables (21/20) (too-many-locals)
R:150, 8: Too many nested blocks (8/5) (too-many-nested-blocks)
************* Module taucmdr.model.target
W:707, 0: FIXME: not implemented (fixme)
R:704, 4: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module taucmdr.model.trial
R:353, 4: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
R:531, 4: Too many local variables (24/20) (too-many-locals)
W:589,24: Exception arguments suggest string formatting might be intended (raising-format-tuple)
************* Module taucmdr.model.experiment
W:109, 4: Parameters differ from overridden 'one' method (arguments-differ)
W:113, 4: Parameters differ from overridden 'all' method (arguments-differ)
W:117, 4: Parameters differ from overridden 'count' method (arguments-differ)
W:123, 4: Parameters differ from overridden 'search' method (arguments-differ)
W:127, 4: Parameters differ from overridden 'exists' method (arguments-differ)
W:134, 4: Useless super delegation in method 'create' (useless-super-delegation)
W:137, 4: Useless super delegation in method 'update' (useless-super-delegation)
W:140, 4: Useless super delegation in method 'unset' (useless-super-delegation)
W:143, 4: Parameters differ from overridden 'delete' method (arguments-differ)
C:432, 4: Missing method docstring (missing-docstring)
Stderror 
Using config file /home/runner/work/taucmdr/taucmdr/pylintrc
zbeekman commented 4 years ago

LGTM! Thanks @PlatinumCD!