Parabeac / parabeac_core

Continuous Design / Continuous Integration for Figma to Flutter
BSD 3-Clause "New" or "Revised" License
579 stars 70 forks source link

Dividers are not being consider on height/width calculation #716

Closed SushiRoll53 closed 2 years ago

SushiRoll53 commented 2 years ago

Describe the bug

When there is a line that goes from Figma to Flutter, Figma consider those lines to be 0 width or height to horizontal or vertical respectively. So when the code is generated it overflows for the divider thickness (usually 1).

To Reproduce

Steps to reproduce the behavior:

  1. Create an autolayout with at least 3 childen
  2. One of those children must be a line created on Figma as a divider
  3. Generate the code & see output

Impact of the problem

Overflow errrors

Environment:

Screenshots

Screen Shot 2022-10-06 at 5 37 42 PM

Additional comments/context:

If applicable, add any additional context related to the bug.

SushiRoll53 commented 2 years ago

This was fixed on PBDL