ParabolInc / parabol

Free online agile retrospective meeting tool
https://www.parabol.co/
Other
1.91k stars 331 forks source link

Carousel scrolls to different meeting type after changing team #4484

Closed avivapinchas closed 3 years ago

avivapinchas commented 3 years ago

Issue - Bug

In the new meeting carousel, I'll first scroll to the meeting type, and then change the team. Sometimes, when I change the team, I'll scroll to a different meeting type. Looks like this might happen when I select Sprint Poker, but I didn't notice what was consistent about this behavior - it happens sometimes.

Here's a video: https://www.loom.com/share/59c7a58380764b02822994f9ea88a731

Acceptance Criteria (optional)

Users can:

mattkrick commented 3 years ago

it's not a bug it's a feature 😄

let's say your product team only runs check-in meetings. and your growth team only runs retros. well, when you select your product team, it will think, "hey, last time you ran a check-in meeting, so i'll set it to that".

in a perfect world, the team dropdown should be selected first & then the meeting type. this is done automatically if you click the "start meeting" button from your team dashboard.

we could implement something that says "if they already changed the meeting type, when they change their team, don't change the meeting type". i'm just not sure how many folks bump into that under the assumption that they enter via the team dash 🤷

avivapinchas commented 3 years ago

Ooh interesting! So I took a look at this in GA - looking at what the 'previous page' was for any views of pages with 'new meeting' - and here's what I'm seeing: What page came before 'new meeting'_

Looks like the plurality of views follow that behavior - 44% come from a team page - but the majority do not. 'New meeting' is when someone switches teams on the page (that'll show a new page, with a new unique ID), so that's about 24% of views, and then 18% of views come from the timeline.

tianrunhe commented 3 years ago

Here's my proposed solution:

  1. When user enters the meeting lobby, it automatically display the last meeting type for that team (i.e., if you comes in from product team dash, you will see the last meeting type for product team)
  2. If user changes team in the meeting lobby, the meeting type stays unchanged

What do you guys think?

avivapinchas commented 3 years ago

So if I change the meeting type, then change the team, my meeting type won't change?

If I'm understanding that correctly, that makes sense to me 👍

tianrunhe commented 3 years ago

Yes that's correct!

2021-01-06 11 43 00