ParabolInc / parabol

Free online agile retrospective meeting tool
https://www.parabol.co/
Other
1.91k stars 331 forks source link

Domain change in Google causing problems #4726

Closed gcrickman closed 3 years ago

gcrickman commented 3 years ago

Issue - Bug

A user 🔒 writes:

For a while now, me and my team colleagues have had issues to join meetings on Parabol. Typically we can log in, but then we can't join the meeting proper. It takes us several attempts, trying several ways to reach the meeting, until we finally get there.

I think this may have started when our employer changed email addresses from @xxxx.eu to @xxxx.com. We log in through Google as @xxxx.com, but when we land in the app our profiles still display as @xxxx.eu.

Another strange effect that I have noticed: sometimes (I think upon login, but not 100% sure), Parabol creates an organization and team for myself, regardless of already existing ones. As a result, right now I am a member of 3 different orgs with name "xxxxx's Org", which are unintended. I have deleted similar ones in the past.

Can this be fixed so that my team doesn't have such a bad experience trying to get into our retrospectives?

tiffanyhan commented 3 years ago

@mattkrick you okay with always generating a random id when creating a new user from google oauth? i don't see the value in the extra conditional logic to either generate a random one or use the google id. as discussed in the previous check-in meeting, it seems we don't use the google id for anything internally, and keeping it for tracking these edge cases isn't a good use of time.

mattkrick commented 3 years ago

heck yeah, let's just give all new google oauth users a random suffix