ParabolInc / parabol

Free online agile retrospective meeting tool
https://www.parabol.co/
Other
1.91k stars 331 forks source link

Refresh GitLab Auth Tokens #6592

Closed nickoferrall closed 2 years ago

nickoferrall commented 2 years ago

In GitLab's May 2022 update, they have deprecated non-expiring tokens and are now expiring tokens after two hours: https://northflank.com/blog/supporting-expiring-oauth-access-tokens-for-gitlab

AC

nickoferrall commented 2 years ago

Current plan:

Dschoordsch commented 2 years ago
  • in the dataLoader, get the token's TTL from Redis

Why would we store the TTL in Redis when the token itself is stored in Postgres? That seems out of place to me.

nickoferrall commented 2 years ago

We could store it in Postgres, but I was thinking Redis because:

nickoferrall commented 2 years ago

@Dschoordsch curious to get your thoughts on the above. I created a PR for this yesterday evening: https://github.com/ParabolInc/parabol/pull/6594

If you feel that the TTL needs to live in Postgres, I'll work on the change today.