search

ParabolInc / parabol

Free online agile retrospective meeting tool
https://www.parabol.co/
Other
1.91k stars 326 forks source link

Bug: Cannot login with Google on Android Chrome #9069

Open Dschoordsch opened 11 months ago

Dschoordsch commented 11 months ago

Trying to login with Google on Android Chrome 117.0.5938.153, Android 11 results in "Error logging in". The issue is caused by window.opener being null. I have multiple Google accounts on that phone.

From the dev tools it looks like the account selection is not opened in the same tab as the redirect, so we end up with 3 windows: main app, google account selection, oauth redirect.

Dschoordsch commented 11 months ago

For now classifying it as P2 as I could not see evidence for customers experiencing this, but that might change.

Dschoordsch commented 10 months ago

I can log in with the same phone on staging 🤔

mattkrick commented 10 months ago

staging uses a different (non-public) OAUTH2 app. I bet google is more secure for public apps. I'm not sure how to solve this! auth0 uses the same logic, but i haven't combed through their issues yet. maybe someone attempted a PR to fix?

https://github.com/auth0/auth0-spa-js/blob/e272225a2b6c0489ab5e7d94cc6dd91987e23087/src/utils.ts#L104-L111

github-actions[bot] commented 3 weeks ago

Stale issue