ParabolInc / parabol

Free online agile retrospective meeting tool
https://www.parabol.co/
Other
1.9k stars 327 forks source link

Release Please must use chore to increment minor version. Today it is incrementing patch version #9086

Open rafaelromcar-parabol opened 10 months ago

rafaelromcar-parabol commented 10 months ago

When Release Please sees a chore commit it will add it to the section Changes on the changelog as it is configured here.

That only increments patch version, not minor version, so releases with fixes and chores only increment the patch version, which isn't correct. Example.

We must adapt Release Please so chores and features are both considered minor versions updates​

mattkrick commented 10 months ago

i don't think we can configure that part, feat bump minor, fix bumps patch. i don't see any other semver triggers. The workaround is to write Release-As: 2.1.0 in the commit

rafaelromcar-parabol commented 10 months ago

I would avoid adding the release-as to a particular merge and just doing a manual commit --allow-empty with Release-As if needed. That would require a manual check and a human decision. Not dramatic, but sadly we can't do much here 😿

mattkrick commented 10 months ago

at the end of the day the version doesn't really matter. it's a app, not a lib, so nothing depends on our app to follow a strict semvar. only other option i see is making every release a new major change & then using the patch number for hotfixes & then we ignore the minor version entirely. feels less fun, but it's an option

mattkrick commented 10 months ago

OR we write feat(release): release v1.0.0.

Dschoordsch commented 10 months ago

I didn't look too close, but I see 2 options:

github-actions[bot] commented 4 months ago

Stale issue

jordanh commented 4 months ago

Came here to scrub this.

This feels like governance, not a backlog issue. @rafaelromcar-parabol what would you like to do here to close this issue?

rafaelromcar-parabol commented 4 months ago

For me it isn't a governance, as it is related with how Release Please is configured and its capabilities.

For me this is a very very very low prio task, but it is something we should do at some point. I would like to test and play with Release Please so the app version increments as minor when there are chores, instead of incrementing patch versions when there are chores.

jordanh commented 4 months ago

Scrubbed again. Adjusted labels.

We'll weigh the priority of this in subsequent cycles or somebody can tackle during cooldown. If it comes stale again, we'll close